From: Scott Wood <scottwood@freescale.com>
To: Tomas Hlavacek <tomas.hlavacek@nic.cz>
Cc: "Martin Strbačka" <martin.strbacka@nic.cz>,
linux-mtd@lists.infradead.org
Subject: Re: Missing support for ECC_SOFT_BCH in fsl-elbc-nand
Date: Mon, 13 Apr 2015 19:58:28 -0500 [thread overview]
Message-ID: <1428973108.22867.656.camel@freescale.com> (raw)
In-Reply-To: <419241df-e18f-42f2-83d8-a6f056a5de74@nic.cz>
On Mon, 2015-04-13 at 23:56 +0200, Tomas Hlavacek wrote:
> Hi!
>
> On Monday, April 13, 2015 9:12:33 PM CEST, Scott Wood wrote:
> > On Mon, 2015-04-13 at 00:30 +0200, Tomas Hlavacek wrote:
> >> 1) How to disable HW ECC?
> >>
> >> What I have done is this:
> >>
> >> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c ...
> >
> > You shouldn't be setting BR_DECC if you don't want to use HW ECC, so
> > this ifdef doesn't accomplish anything.
> >
> > Also, while a compile-time hack may be suitable for your own use, to get
> > a mergable patch it should be a runtime decision. You should be able to
> > read at runtime the level of ECC that the flash requires.
>
> How? Could you please point me to some starting point what to read in order
> to implement it?
The information should be in the chip's identification bytes, either via
ONFI or a manufacturer-specific format. Or, if that's too complicated,
at least indicate the type of ECC to be used in the device tree.
-Scott
prev parent reply other threads:[~2015-04-14 0:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 14:13 Missing support for ECC_SOFT_BCH in fsl-elbc-nand Martin Strbačka
2015-03-27 16:02 ` Richard Weinberger
2015-03-30 8:35 ` Martin Strbačka
2015-03-30 14:20 ` Richard Weinberger
2015-04-10 2:25 ` Scott Wood
2015-04-12 22:30 ` Tomas Hlavacek
2015-04-13 19:12 ` Scott Wood
2015-04-13 21:56 ` Tomas Hlavacek
2015-04-14 0:58 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428973108.22867.656.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.strbacka@nic.cz \
--cc=tomas.hlavacek@nic.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).