Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

[Scott Wood]

On Tue, 2015-05-12 at 03:49 -0500, Bharat Bhushan wrote:
> From: Jaiprakash Singh <b44839@freescale.com>
> 
> IFC IO accressor are set at run time based
> on IFC IP registers endianness.IFC node in
> DTS file contains information about
> endianness.
> 
> Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> ---
>  Tested on T1040RDB, LS2085a, LS1
> 
>  .../bindings/memory-controllers/fsl/ifc.txt        |    3 +
>  drivers/memory/fsl_ifc.c                           |   43 +++-
>  drivers/mtd/nand/fsl_ifc_nand.c                    |  258 ++++++++++----------
>  include/linux/fsl_ifc.h                            |   50 ++++
>  4 files changed, 213 insertions(+), 141 deletions(-)

As before,
Acked-by: Scott Wood <scottwood@freescale.com>

This touches MTD as well as dependencies outside MTD -- which tree
should it go through?

-Scott

Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

[Brian Norris]

On Tue, May 12, 2015 at 08:55:51AM -0500, Scott Wood wrote:
> On Tue, 2015-05-12 at 03:49 -0500, Bharat Bhushan wrote:
> > From: Jaiprakash Singh <b44839@freescale.com>
> > 
> > IFC IO accressor are set at run time based
> > on IFC IP registers endianness.IFC node in
> > DTS file contains information about
> > endianness.
> > 
> > Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> > ---
> >  Tested on T1040RDB, LS2085a, LS1
> > 
> >  .../bindings/memory-controllers/fsl/ifc.txt        |    3 +
> >  drivers/memory/fsl_ifc.c                           |   43 +++-
> >  drivers/mtd/nand/fsl_ifc_nand.c                    |  258 ++++++++++----------
> >  include/linux/fsl_ifc.h                            |   50 ++++
> >  4 files changed, 213 insertions(+), 141 deletions(-)
> 
> As before,
> Acked-by: Scott Wood <scottwood@freescale.com>
> 
> This touches MTD as well as dependencies outside MTD -- which tree
> should it go through?

I haven't actually seen the patch on linux-mtd. Were we CC'd? If not,
please resend, and CC linux-mtd@lists.infradead.org. (Try
scripts/get_maintainer.pl to find the right people/lists.)

And is this the previous version?

http://lists.infradead.org/pipermail/linux-mtd/2014-November/056249.html

I don't mind either tree. I don't think fsl_ifc_nand.c will have
anything noisy in linux-mtd for this release cycle.

Brian

Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

[Scott Wood]

On Tue, 2015-05-19 at 15:01 -0700, Brian Norris wrote:
> On Tue, May 12, 2015 at 08:55:51AM -0500, Scott Wood wrote:
> > On Tue, 2015-05-12 at 03:49 -0500, Bharat Bhushan wrote:
> > > From: Jaiprakash Singh <b44839@freescale.com>
> > > 
> > > IFC IO accressor are set at run time based
> > > on IFC IP registers endianness.IFC node in
> > > DTS file contains information about
> > > endianness.
> > > 
> > > Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> > > ---
> > >  Tested on T1040RDB, LS2085a, LS1
> > > 
> > >  .../bindings/memory-controllers/fsl/ifc.txt        |    3 +
> > >  drivers/memory/fsl_ifc.c                           |   43 +++-
> > >  drivers/mtd/nand/fsl_ifc_nand.c                    |  258 ++++++++++----------
> > >  include/linux/fsl_ifc.h                            |   50 ++++
> > >  4 files changed, 213 insertions(+), 141 deletions(-)
> > 
> > As before,
> > Acked-by: Scott Wood <scottwood@freescale.com>
> > 
> > This touches MTD as well as dependencies outside MTD -- which tree
> > should it go through?
> 
> I haven't actually seen the patch on linux-mtd. Were we CC'd? If not,
> please resend, and CC linux-mtd@lists.infradead.org. (Try
> scripts/get_maintainer.pl to find the right people/lists.)

linux-mtd@lists.infradead.org was in the To: header.

One possible problem is that Bharat sent the patch with a bad
(intranet) e-mail address (I've corrected in this e-mail); this may
have gotten the patch spam filtered by the maillist server.  Bharat,
please fix your git send-mail configuration (and don't use rhuath as a
development machine).

...though, the previous postings were made by Jaiprakesh with a valid
e-mail address, so maybe something else about the patch is hitting a
filter.  CCing mailman@lists.infradead.org; can someone check logs to
see if the list received these e-mails (e.g. v4 sent on December 8th by
Jaiprakesh, message id
<1418017580-2749-1-git-send-email-b44839@freescale.com>)?

> And is this the previous version?
> 
> http://lists.infradead.org/pipermail/linux-mtd/2014-November/056249.html

It's a previous version, though the current version was previously sent
as v4.

> I don't mind either tree. I don't think fsl_ifc_nand.c will have
> anything noisy in linux-mtd for this release cycle.

OK.  I'll resend the patch, as my e-mails seem to get through; please
either ack or apply (assuming no problems with it).

-Scott

Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

[Brian Norris]

+ David

On Wed, May 20, 2015 at 6:49 PM, Scott Wood <scottwood@freescale.com> wrote:
> On Tue, 2015-05-19 at 15:01 -0700, Brian Norris wrote:
>> I haven't actually seen the patch on linux-mtd. Were we CC'd? If not,
>> please resend, and CC linux-mtd@lists.infradead.org. (Try
>> scripts/get_maintainer.pl to find the right people/lists.)
>
> linux-mtd@lists.infradead.org was in the To: header.
>
> One possible problem is that Bharat sent the patch with a bad
> (intranet) e-mail address (I've corrected in this e-mail); this may
> have gotten the patch spam filtered by the maillist server.  Bharat,
> please fix your git send-mail configuration (and don't use rhuath as a
> development machine).
>
> ...though, the previous postings were made by Jaiprakesh with a valid
> e-mail address, so maybe something else about the patch is hitting a
> filter.  CCing mailman@lists.infradead.org; can someone check logs to
> see if the list received these e-mails (e.g. v4 sent on December 8th by
> Jaiprakesh, message id
> <1418017580-2749-1-git-send-email-b44839@freescale.com>)?

I have admin access now, and this message doesn't show up in the 'Held
Mesages' view. It seems like the message never even made it to the
list. I'm a little unfamiliar with mailman, though, so I don't know if
there's a way to see a full log of received messages.

For Bharat's sake: if you're ever in doubt, you can double check the
MTD archives to make sure your messages got through:

http://lists.infradead.org/pipermail/linux-mtd/

>> And is this the previous version?
>>
>> http://lists.infradead.org/pipermail/linux-mtd/2014-November/056249.html
>
> It's a previous version, though the current version was previously sent
> as v4.

Well that's a bit confusing too. It'd be nice if we kept the version
numbering linear...

Brian

Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

[Scott Wood]

On Wed, 2015-05-20 at 20:49 -0500, Scott Wood wrote:
> > I don't mind either tree. I don't think fsl_ifc_nand.c will have
> > anything noisy in linux-mtd for this release cycle.
> 
> OK.  I'll resend the patch, as my e-mails seem to get through; please
> either ack or apply (assuming no problems with it).

...and now it's telling me my last e-mail was held for moderation due to
being a non-member, even though I'm subscribed to linux-mtd using this
e-mail address. :-(

-Scott

Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

[Brian Norris]

On Wed, May 20, 2015 at 7:01 PM, Scott Wood <scottwood@freescale.com> wrote:
> On Wed, 2015-05-20 at 20:49 -0500, Scott Wood wrote:
>> > I don't mind either tree. I don't think fsl_ifc_nand.c will have
>> > anything noisy in linux-mtd for this release cycle.
>>
>> OK.  I'll resend the patch, as my e-mails seem to get through; please
>> either ack or apply (assuming no problems with it).
>
> ...and now it's telling me my last e-mail was held for moderation due to
> being a non-member, even though I'm subscribed to linux-mtd using this
> e-mail address. :-(

I got the same. But if you read carefully, it's because you sent to
mailman@llists.infradead.org. That's either not a valid email, or it's
actually a mailing list that you're not subscribed to.

Brian

Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

[Scott Wood]

On Wed, 2015-05-20 at 19:04 -0700, Brian Norris wrote:
> On Wed, May 20, 2015 at 7:01 PM, Scott Wood <scottwood@freescale.com> wrote:
> > On Wed, 2015-05-20 at 20:49 -0500, Scott Wood wrote:
> >> > I don't mind either tree. I don't think fsl_ifc_nand.c will have
> >> > anything noisy in linux-mtd for this release cycle.
> >>
> >> OK.  I'll resend the patch, as my e-mails seem to get through; please
> >> either ack or apply (assuming no problems with it).
> >
> > ...and now it's telling me my last e-mail was held for moderation due to
> > being a non-member, even though I'm subscribed to linux-mtd using this
> > e-mail address. :-(
> 
> I got the same. But if you read carefully, it's because you sent to
> mailman@llists.infradead.org. That's either not a valid email, or it's
> actually a mailing list that you're not subscribed to.

I looked carefully at the e-mails in my sent folder and I don't see
"llists".

I CCed mailmain@lists.infradead.org because
http://lists.infradead.org/mailman/listinfo says, "If you are having
trouble using the lists, please contact mailman@lists.infradead.org."  I
didn't realize that was a mailing list rather than an admin contact
address.

-Scott

Re: [PATCH 1/1] [RESEND] IFC: Change IO accessor based on endianness

[Brian Norris]

On Wed, May 20, 2015 at 7:14 PM, Scott Wood <scottwood@freescale.com> wrote:
> On Wed, 2015-05-20 at 19:04 -0700, Brian Norris wrote:
>> On Wed, May 20, 2015 at 7:01 PM, Scott Wood <scottwood@freescale.com> wrote:
>> > On Wed, 2015-05-20 at 20:49 -0500, Scott Wood wrote:
>> >> > I don't mind either tree. I don't think fsl_ifc_nand.c will have
>> >> > anything noisy in linux-mtd for this release cycle.
>> >>
>> >> OK.  I'll resend the patch, as my e-mails seem to get through; please
>> >> either ack or apply (assuming no problems with it).
>> >
>> > ...and now it's telling me my last e-mail was held for moderation due to
>> > being a non-member, even though I'm subscribed to linux-mtd using this
>> > e-mail address. :-(
>>
>> I got the same. But if you read carefully, it's because you sent to
>> mailman@llists.infradead.org. That's either not a valid email, or it's
>> actually a mailing list that you're not subscribed to.
>
> I looked carefully at the e-mails in my sent folder and I don't see
> "llists".

Ugh, typo, sorry :( Should have been "lists"

> I CCed mailmain@lists.infradead.org because
> http://lists.infradead.org/mailman/listinfo says, "If you are having
> trouble using the lists, please contact mailman@lists.infradead.org."  I
> didn't realize that was a mailing list rather than an admin contact
> address.

Ah, OK. I have no idea what that mailing list is doing.

BTW, the linux-mtd page:

http://lists.infradead.org/mailman/listinfo/linux-mtd

says "linux-mtd list run by postmaster at lists.infradead.org", but
that address actually links to
"mailto:linux-mtd-owner@lists.infradead.org". This is all highly
confusing.

Perhaps David can shed light on this?

Brian