From: Artem Bityutskiy <dedekind1@gmail.com>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
richard.weinberger@gmail.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v4] ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs
Date: Mon, 10 Aug 2015 11:32:11 +0300 [thread overview]
Message-ID: <1439195531.26877.103.camel@gmail.com> (raw)
In-Reply-To: <1438304996-31502-1-git-send-email-yangds.fnst@cn.fujitsu.com>
Could you please describe how you tested your patch. Did you run stress
tests with atime enabled, which ones?
On Fri, 2015-07-31 at 09:09 +0800, Dongsheng Yang wrote:
> +> > > sb->s_flags |= MS_ACTIVE;
> +#ifndef CONFIG_UBIFS_ATIME_SUPPORT
> +> > > sb->s_flags |= MS_NOATIME;
> +#else
> +> > > ubifs_warn(c, "************WARNING START****************");
> +> > > ubifs_warn(c, "Ubifs is supporting atime now, that would");
> +> > > ubifs_warn(c, "probably damage your flash. If you are not");
> +> > > ubifs_warn(c, "sure about it, please set UBIFS_ATIME_SUPPORT");
> +> > > ubifs_warn(c, "to 'N'.");
> +> > > ubifs_warn(c, "************WARNING END******************");
Could we please be a little be less scary.
1. I think these starting and ending "*****" lines are unnecessary.
2. Ah, and use "UBIFS", not "Ubifs" please.
3. Let's be shorter, just this should be enough:
ubifs_warn("full atime support is enabled, which may wear out your
flash faster");
Artem.
next prev parent reply other threads:[~2015-08-10 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 1:09 [PATCH v4] ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs Dongsheng Yang
2015-08-10 8:32 ` Artem Bityutskiy [this message]
2015-08-11 2:02 ` Dongsheng Yang
2015-08-12 9:57 ` Artem Bityutskiy
2015-08-18 4:37 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439195531.26877.103.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).