From: Saurabh Sengar <saurabh.truth@gmail.com>
To: joern@lazybastard.org, dwmw2@infradead.org,
computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Saurabh Sengar <saurabh.truth@gmail.com>
Subject: [PATCH] mtd: phram: error handling
Date: Sun, 8 Nov 2015 14:17:20 +0530 [thread overview]
Message-ID: <1446972440-3795-1-git-send-email-saurabh.truth@gmail.com> (raw)
registering the device with NULL pointer can lead to crash,
hence fixing it.
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
in case of 'illegal start address' or 'illegal device length', name pointer is getting freed.
we shouldn't register the device with NULL pointer.
drivers/mtd/devices/phram.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index 8b66e52..9a7aed3 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -249,12 +249,14 @@ static int phram_setup(const char *val)
if (ret) {
kfree(name);
parse_err("illegal start address\n");
+ goto err;
}
ret = parse_num64(&len, token[2]);
if (ret) {
kfree(name);
parse_err("illegal device length\n");
+ goto err;
}
ret = register_device(name, start, len);
@@ -262,7 +264,7 @@ static int phram_setup(const char *val)
pr_info("%s device: %#llx at %#llx\n", name, len, start);
else
kfree(name);
-
+err:
return ret;
}
--
1.9.1
next reply other threads:[~2015-11-08 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 8:47 Saurabh Sengar [this message]
2015-11-08 21:23 ` [PATCH] mtd: phram: error handling Andy Shevchenko
2015-11-09 6:23 ` [PATCH v2] " Saurabh Sengar
2015-11-10 18:20 ` Brian Norris
2015-11-10 18:33 ` [PATCH] " Joe Perches
2015-11-10 18:39 ` Brian Norris
2015-11-10 18:45 ` Joe Perches
2015-11-10 19:03 ` Brian Norris
2015-11-10 19:27 ` Saurabh Sengar
2015-11-10 19:41 ` Brian Norris
2015-11-11 8:23 ` Saurabh Sengar
2015-11-11 19:44 ` Brian Norris
2015-11-12 6:23 ` Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446972440-3795-1-git-send-email-saurabh.truth@gmail.com \
--to=saurabh.truth@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).