From: Joe Perches <joe@perches.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Saurabh Sengar <saurabh.truth@gmail.com>,
andy.shevchenko@gmail.com, joern@lazybastard.org,
dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: phram: error handling
Date: Tue, 10 Nov 2015 10:45:55 -0800 [thread overview]
Message-ID: <1447181155.2701.72.camel@perches.com> (raw)
In-Reply-To: <20151110183956.GQ12143@google.com>
On Tue, 2015-11-10 at 10:39 -0800, Brian Norris wrote:
> On Tue, Nov 10, 2015 at 10:33:07AM -0800, Joe Perches wrote:
> > Expand parse_err macro with hidden flow in-place.
> > Remove the now unused parse_err macro.
[]
> I think -EINVAL makes more sense than 1. That
> could be a subsequent patch, I suppose.
That means you have to trace all the callers
to verify that converting 1 to -22 is acceptable.
Maybe Saurabh wants to do that.
next prev parent reply other threads:[~2015-11-10 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 8:47 [PATCH] mtd: phram: error handling Saurabh Sengar
2015-11-08 21:23 ` Andy Shevchenko
2015-11-09 6:23 ` [PATCH v2] " Saurabh Sengar
2015-11-10 18:20 ` Brian Norris
2015-11-10 18:33 ` [PATCH] " Joe Perches
2015-11-10 18:39 ` Brian Norris
2015-11-10 18:45 ` Joe Perches [this message]
2015-11-10 19:03 ` Brian Norris
2015-11-10 19:27 ` Saurabh Sengar
2015-11-10 19:41 ` Brian Norris
2015-11-11 8:23 ` Saurabh Sengar
2015-11-11 19:44 ` Brian Norris
2015-11-12 6:23 ` Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447181155.2701.72.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).