Re: [PATCH v2 1/1] mtd: mtdram: Add parameter for setting writebuf size

["Bityutskiy, Artem" <artem.bityutskiy@intel.com>]

On Wed, 2016-03-02 at 16:32 +0200, Artem Bityutskiy wrote:
> On Wed, 2016-03-02 at 14:06 +0100, Alexander Stein wrote:
> > 
> > +config MTDRAM_WRITEBUF_SIZE
> > +       int "MTDRAM write buf size in Bytes"
> > +       depends on MTD_MTDRAM
> > +       default "64"
> > +       help
> > +         This allows you to configure the write buffer size in the
> > device
> > +         emulated by the MTDRAM driver.  If the MTDRAM driver is
> > built
> > +         as a module, it is also possible to specify this as a
> > parameter when
> > +         loading the module. E.g. ubifs relies this in the
> > recovery
> > algorithm.
> Why another Kconfig option (compile-time) instead of just a module
> parameter (run-time), which would be more flexible?

Oh, pardon, you are adding both. I never found the Kconfig options very
useful. Quite the opposite, I always thought MTD has too many of those
little Kconfig options and the config menu is too large. I'd suggest to
only add the runtime option, unless you really need the Kconfig option
too (why?).

-- 
Best Regards,
Artem Bityutskiy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.