From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Han Xu <han.xu@nxp.com>, Michal Suchanek <hramrach@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Rafal Milecki <zajec5@gmail.com>, Jagan Teki <jteki@openedev.com>,
"Andrew F. Davis" <afd@ti.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Gabor Juhos <juhosg@openwrt.org>, Bean Huo <beanhuo@micron.com>,
linux-kernel@vger.kernel.org,
Bayi Cheng <bayi.cheng@mediatek.com>,
Joachim Eastwood <manabian@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>
Subject: [PATCH v7 03/10] mtd: fsl-quadspi: return amount of data read/written or error
Date: Thu, 5 May 2016 17:31:49 -0700 [thread overview]
Message-ID: <1462494716-95312-4-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1462494716-95312-1-git-send-email-computersforpeace@gmail.com>
From: Michal Suchanek <hramrach@gmail.com>
Return amount of data read/written or error as read(2)/write(2) does.
Signed-off-by: Michal Suchanek <hramrach@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
v6 -> v7:
* moved some *retlen changes to patch 7 to preserve bisectability
drivers/mtd/spi-nor/fsl-quadspi.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 74dc155e1b3b..ea296769f015 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -618,7 +618,7 @@ static inline void fsl_qspi_invalid(struct fsl_qspi *q)
qspi_writel(q, reg, q->iobase + QUADSPI_MCR);
}
-static int fsl_qspi_nor_write(struct fsl_qspi *q, struct spi_nor *nor,
+static ssize_t fsl_qspi_nor_write(struct fsl_qspi *q, struct spi_nor *nor,
u8 opcode, unsigned int to, u32 *txbuf,
unsigned count, size_t *retlen)
{
@@ -647,8 +647,11 @@ static int fsl_qspi_nor_write(struct fsl_qspi *q, struct spi_nor *nor,
/* Trigger it */
ret = fsl_qspi_runcmd(q, opcode, to, count);
- if (ret == 0 && retlen)
- *retlen += count;
+ if (ret == 0) {
+ if (retlen)
+ *retlen += count;
+ return count;
+ }
return ret;
}
@@ -860,6 +863,8 @@ static int fsl_qspi_write_reg(struct spi_nor *nor, u8 opcode, u8 *buf, int len)
} else if (len > 0) {
ret = fsl_qspi_nor_write(q, nor, opcode, 0,
(u32 *)buf, len, NULL);
+ if (ret > 0)
+ return 0;
} else {
dev_err(q->dev, "invalid cmd %d\n", opcode);
ret = -EINVAL;
@@ -873,12 +878,12 @@ static ssize_t fsl_qspi_write(struct spi_nor *nor, loff_t to,
{
struct fsl_qspi *q = nor->priv;
- fsl_qspi_nor_write(q, nor, nor->program_opcode, to,
+ ssize_t ret = fsl_qspi_nor_write(q, nor, nor->program_opcode, to,
(u32 *)buf, len, retlen);
/* invalid the data in the AHB buffer. */
fsl_qspi_invalid(q);
- return 0;
+ return ret;
}
static ssize_t fsl_qspi_read(struct spi_nor *nor, loff_t from,
@@ -925,7 +930,7 @@ static ssize_t fsl_qspi_read(struct spi_nor *nor, loff_t from,
len);
*retlen += len;
- return 0;
+ return len;
}
static int fsl_qspi_erase(struct spi_nor *nor, loff_t offs)
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-05-06 0:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 0:31 [PATCH v7 00/10] Add error checking to spi-nor read and write Brian Norris
2016-05-06 0:31 ` [PATCH v7 01/10] mtd: spi-nor: change return value of read/write Brian Norris
2016-05-06 0:31 ` [PATCH v7 02/10] mtd: m25p80: return amount of data transferred or error in read/write Brian Norris
2016-05-06 0:31 ` Brian Norris [this message]
2016-05-06 0:31 ` [PATCH v7 04/10] mtd: mtk-quadspi: " Brian Norris
2016-05-06 0:31 ` [PATCH v7 05/10] mtd: nxp-spifi: " Brian Norris
2016-05-06 0:31 ` [PATCH v7 06/10] mtd: spi-nor: check return value from write Brian Norris
2016-05-06 0:31 ` [PATCH v7 07/10] mtd: spi-nor: stop passing around retlen Brian Norris
2016-05-06 0:31 ` [PATCH v7 08/10] mtd: spi-nor: simplify write loop Brian Norris
2016-05-06 0:31 ` [PATCH v7 09/10] mtd: spi-nor: add read loop Brian Norris
2016-05-06 0:31 ` [PATCH v7 10/10] mtd: m25p80: read in spi_max_transfer_size chunks Brian Norris
2016-05-16 19:47 ` [PATCH v7 00/10] Add error checking to spi-nor read and write Michal Suchanek
2016-05-18 1:24 ` Brian Norris
2016-05-26 20:12 ` Michal Suchanek
2016-05-23 16:08 ` Cyrille Pitchen
2016-06-02 0:26 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462494716-95312-4-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=afd@ti.com \
--cc=bayi.cheng@mediatek.com \
--cc=beanhuo@micron.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@atmel.com \
--cc=han.xu@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=hramrach@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jteki@openedev.com \
--cc=juhosg@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manabian@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).