From: Salah Triki <salah.triki@acm.org>
To: richard@nod.at, dedekind1@gmail.com, adrian.hunter@intel.com
Cc: Salah Triki <salah.triki@acm.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc
Date: Thu, 26 May 2016 15:28:57 +0100 [thread overview]
Message-ID: <1464272937-6629-1-git-send-email-salah.triki@acm.org> (raw)
Code is more readable when using kmem_cache_zalloc instead of kmem_cache_alloc/memset.
Signed-off-by: Salah Triki <salah.triki@acm.org>
---
fs/ubifs/super.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 7034995..f509200 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -262,12 +262,10 @@ static struct inode *ubifs_alloc_inode(struct super_block *sb)
{
struct ubifs_inode *ui;
- ui = kmem_cache_alloc(ubifs_inode_slab, GFP_NOFS);
+ ui = kmem_cache_zalloc(ubifs_inode_slab, GFP_NOFS);
if (!ui)
return NULL;
- memset((void *)ui + sizeof(struct inode), 0,
- sizeof(struct ubifs_inode) - sizeof(struct inode));
mutex_init(&ui->ui_mutex);
spin_lock_init(&ui->ui_lock);
return &ui->vfs_inode;
--
1.9.1
next reply other threads:[~2016-05-26 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 14:28 Salah Triki [this message]
2016-05-26 14:33 ` [PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464272937-6629-1-git-send-email-salah.triki@acm.org \
--to=salah.triki@acm.org \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).