Re: [PATCH v2 2/6] mtd: nand: gpmi: document the clocks and clock-names in DT property

Rob Herring
2016-06-14T12:46:37Z

On Fri, Jun 10, 2016 at 12:01:30PM -0500, Han Xu wrote:
> add the clocks and clock-names in DT property, gpmi-io clock is
> mandatory for all platforms, but some platforms, such as i.MX6Q may
> need more extra clocks for submodules. More details please refer to the
> SoC reference manual.
>
> Signed-off-by: Han Xu <han.xu@nxp.com>
> ---
> Documentation/devicetree/bindings/mtd/gpmi-nand.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
> index d02acaf..c8d0e2f 100644
> --- a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
> @@ -13,6 +13,13 @@ Required properties:
> and GPMI DMA channel ID.
> Refer to dma.txt and fsl-mxs-dma.txt for details.
> - dma-names: Must be "rx-tx".
> + - clocks : The clocks needed by the gpmi controller. This field varies
> + depends on the SoC design, "gpmi-io" is mandatory but some platforms may
> + need several extra clocks, such as i.MX6Q, it requires "gpmi_apb,
> + gpmi_bch, gpmi_bch_apb and per1_bch" for all submodules. Please refer to
> + the HW design manual.

You need to spell out exactly which clocks each chip/compatible string
has.

I'm generally suspicious of varying number of clocks. My guess is all
the versions have the additional clocks, but they are all just tied to
the same parent.

Rob