* [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape
@ 2016-07-01 16:02 Raghav Dogra
2016-07-04 9:29 ` Boris Brezillon
2016-07-09 1:04 ` Scott Wood
0 siblings, 2 replies; 6+ messages in thread
From: Raghav Dogra @ 2016-07-01 16:02 UTC (permalink / raw)
To: linux-mtd
Cc: boris.brezillon, computersforpeace, leoyang.li, oss,
prabhakar.kushwaha, Raghav Dogra
This patch enables IFC NAND support on ARM layerscape platform.
It fixes the dependency to enable NAND. The include files are being modified
to ensure complilation for both PowerPC and ARM architectures.
Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
---
Applicable to git://git.infradead.org/l2-mtd.git
Changes for v2: updated commit description
drivers/memory/Kconfig | 2 +-
drivers/memory/fsl_ifc.c | 4 +++-
drivers/mtd/nand/Kconfig | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 81ddb17..5645705 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -104,7 +104,7 @@ config FSL_CORENET_CF
config FSL_IFC
bool
- depends on FSL_SOC
+ depends on FSL_SOC || ARCH_LAYERSCAPE
config JZ4780_NEMC
bool "Ingenic JZ4780 SoC NEMC driver"
diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
index 904b4af..1b182b1 100644
--- a/drivers/memory/fsl_ifc.c
+++ b/drivers/memory/fsl_ifc.c
@@ -31,7 +31,9 @@
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/fsl_ifc.h>
-#include <asm/prom.h>
+#include <linux/irqdomain.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev;
EXPORT_SYMBOL(fsl_ifc_ctrl_dev);
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index f05e0e9..eace3ef 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC
config MTD_NAND_FSL_IFC
tristate "NAND support for Freescale IFC controller"
- depends on MTD_NAND && FSL_SOC
+ depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE)
select FSL_IFC
select MEMORY
help
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape
2016-07-01 16:02 [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape Raghav Dogra
@ 2016-07-04 9:29 ` Boris Brezillon
2016-07-04 9:49 ` Benjamin Herrenschmidt
2016-07-09 1:04 ` Scott Wood
1 sibling, 1 reply; 6+ messages in thread
From: Boris Brezillon @ 2016-07-04 9:29 UTC (permalink / raw)
To: Raghav Dogra, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman
Cc: linux-mtd, prabhakar.kushwaha, leoyang.li, oss, computersforpeace,
linuxppc-dev
+PPC maintainers.
Hi Raghav,
Since you're touching powerpc drivers, the least you could do is add
ppc maintainers in Cc, so that they can ack/review your patch...
On Fri, 1 Jul 2016 21:32:30 +0530
Raghav Dogra <raghav.dogra@nxp.com> wrote:
> This patch enables IFC NAND support on ARM layerscape platform.
> It fixes the dependency to enable NAND. The include files are being modified
> to ensure complilation for both PowerPC and ARM architectures.
Still think this could be separated in 2 commits:
- the first one getting rid of the asm/prom.h inclusion
- the second one changing the Kconfig dependency
>
> Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> ---
> Applicable to git://git.infradead.org/l2-mtd.git
>
> Changes for v2: updated commit description
>
> drivers/memory/Kconfig | 2 +-
> drivers/memory/fsl_ifc.c | 4 +++-
> drivers/mtd/nand/Kconfig | 2 +-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 81ddb17..5645705 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -104,7 +104,7 @@ config FSL_CORENET_CF
>
> config FSL_IFC
> bool
> - depends on FSL_SOC
> + depends on FSL_SOC || ARCH_LAYERSCAPE
>
> config JZ4780_NEMC
> bool "Ingenic JZ4780 SoC NEMC driver"
> diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
> index 904b4af..1b182b1 100644
> --- a/drivers/memory/fsl_ifc.c
> +++ b/drivers/memory/fsl_ifc.c
> @@ -31,7 +31,9 @@
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/fsl_ifc.h>
> -#include <asm/prom.h>
> +#include <linux/irqdomain.h>
> +#include <linux/of_address.h>
> +#include <linux/of_irq.h>
>
> struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev;
> EXPORT_SYMBOL(fsl_ifc_ctrl_dev);
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f05e0e9..eace3ef 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC
>
> config MTD_NAND_FSL_IFC
> tristate "NAND support for Freescale IFC controller"
> - depends on MTD_NAND && FSL_SOC
> + depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE)
> select FSL_IFC
> select MEMORY
> help
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape
2016-07-04 9:29 ` Boris Brezillon
@ 2016-07-04 9:49 ` Benjamin Herrenschmidt
2016-07-04 9:53 ` Raghav Dogra
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2016-07-04 9:49 UTC (permalink / raw)
To: Boris Brezillon, Raghav Dogra, Paul Mackerras, Michael Ellerman,
Scott Wood
Cc: linux-mtd, prabhakar.kushwaha, leoyang.li, oss, computersforpeace,
linuxppc-dev
On Mon, 2016-07-04 at 11:29 +0200, Boris Brezillon wrote:
> +PPC maintainers.
+ Scott for FSL stuff
> Hi Raghav,
>
> Since you're touching powerpc drivers, the least you could do is add
> ppc maintainers in Cc, so that they can ack/review your patch...
>
> On Fri, 1 Jul 2016 21:32:30 +0530
> Raghav Dogra <raghav.dogra@nxp.com> wrote:
>
> > This patch enables IFC NAND support on ARM layerscape platform.
> > It fixes the dependency to enable NAND. The include files are being
> > modified
> > to ensure complilation for both PowerPC and ARM architectures.
>
> Still think this could be separated in 2 commits:
> - the first one getting rid of the asm/prom.h inclusion
> - the second one changing the Kconfig dependency
>
> >
> > Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> > ---
> > Applicable to git://git.infradead.org/l2-mtd.git
> >
> > Changes for v2: updated commit description
> >
> > drivers/memory/Kconfig | 2 +-
> > drivers/memory/fsl_ifc.c | 4 +++-
> > drivers/mtd/nand/Kconfig | 2 +-
> > 3 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> > index 81ddb17..5645705 100644
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -104,7 +104,7 @@ config FSL_CORENET_CF
> >
> > config FSL_IFC
> > bool
> > - depends on FSL_SOC
> > + depends on FSL_SOC || ARCH_LAYERSCAPE
> >
> > config JZ4780_NEMC
> > bool "Ingenic JZ4780 SoC NEMC driver"
> > diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
> > index 904b4af..1b182b1 100644
> > --- a/drivers/memory/fsl_ifc.c
> > +++ b/drivers/memory/fsl_ifc.c
> > @@ -31,7 +31,9 @@
> > #include <linux/of_device.h>
> > #include <linux/platform_device.h>
> > #include <linux/fsl_ifc.h>
> > -#include <asm/prom.h>
> > +#include <linux/irqdomain.h>
> > +#include <linux/of_address.h>
> > +#include <linux/of_irq.h>
> >
> > struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev;
> > EXPORT_SYMBOL(fsl_ifc_ctrl_dev);
> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > index f05e0e9..eace3ef 100644
> > --- a/drivers/mtd/nand/Kconfig
> > +++ b/drivers/mtd/nand/Kconfig
> > @@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC
> >
> > config MTD_NAND_FSL_IFC
> > tristate "NAND support for Freescale IFC controller"
> > - depends on MTD_NAND && FSL_SOC
> > + depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE)
> > select FSL_IFC
> > select MEMORY
> > help
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape
2016-07-04 9:49 ` Benjamin Herrenschmidt
@ 2016-07-04 9:53 ` Raghav Dogra
0 siblings, 0 replies; 6+ messages in thread
From: Raghav Dogra @ 2016-07-04 9:53 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Boris Brezillon, Paul Mackerras,
Michael Ellerman, Scott Wood
Cc: linux-mtd@lists.infradead.org, Prabhakar Kushwaha, Yang-Leo Li,
oss@buserror.net, computersforpeace@gmail.com,
linuxppc-dev@lists.ozlabs.org
Scott uses the updated email id <oss@buserror.net> and is already added.
Regards,
Raghav
> -----Original Message-----
> From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org]
> Sent: Monday, July 04, 2016 3:19 PM
> To: Boris Brezillon <boris.brezillon@free-electrons.com>; Raghav Dogra
> <raghav.dogra@nxp.com>; Paul Mackerras <paulus@samba.org>; Michael
> Ellerman <mpe@ellerman.id.au>; Scott Wood <scottwood@freescale.com>
> Cc: linux-mtd@lists.infradead.org; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; Yang-Leo Li <leoyang.li@nxp.com>;
> oss@buserror.net; computersforpeace@gmail.com; linuxppc-
> dev@lists.ozlabs.org
> Subject: Re: [PATCH][v2] driver/memory: Update dependency of IFC for
> Layerscape
>
> On Mon, 2016-07-04 at 11:29 +0200, Boris Brezillon wrote:
> > +PPC maintainers.
>
> + Scott for FSL stuff
>
> > Hi Raghav,
> >
> > Since you're touching powerpc drivers, the least you could do is add
> > ppc maintainers in Cc, so that they can ack/review your patch...
> >
> > On Fri, 1 Jul 2016 21:32:30 +0530
> > Raghav Dogra <raghav.dogra@nxp.com> wrote:
> >
> > > This patch enables IFC NAND support on ARM layerscape platform.
> > > It fixes the dependency to enable NAND. The include files are being
> > > modified to ensure complilation for both PowerPC and ARM
> > > architectures.
> >
> > Still think this could be separated in 2 commits:
> > - the first one getting rid of the asm/prom.h inclusion
> > - the second one changing the Kconfig dependency
> >
> > >
> > > Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> > > ---
> > > Applicable to git://git.infradead.org/l2-mtd.git
> > >
> > > Changes for v2: updated commit description
> > >
> > > drivers/memory/Kconfig | 2 +-
> > > drivers/memory/fsl_ifc.c | 4 +++-
> > > drivers/mtd/nand/Kconfig | 2 +-
> > > 3 files changed, 5 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index
> > > 81ddb17..5645705 100644
> > > --- a/drivers/memory/Kconfig
> > > +++ b/drivers/memory/Kconfig
> > > @@ -104,7 +104,7 @@ config FSL_CORENET_CF
> > >
> > > config FSL_IFC
> > > bool
> > > - depends on FSL_SOC
> > > + depends on FSL_SOC || ARCH_LAYERSCAPE
> > >
> > > config JZ4780_NEMC
> > > bool "Ingenic JZ4780 SoC NEMC driver"
> > > diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
> > > index 904b4af..1b182b1 100644
> > > --- a/drivers/memory/fsl_ifc.c
> > > +++ b/drivers/memory/fsl_ifc.c
> > > @@ -31,7 +31,9 @@
> > > #include <linux/of_device.h>
> > > #include <linux/platform_device.h>
> > > #include <linux/fsl_ifc.h>
> > > -#include <asm/prom.h>
> > > +#include <linux/irqdomain.h>
> > > +#include <linux/of_address.h>
> > > +#include <linux/of_irq.h>
> > >
> > > struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev;
> > > EXPORT_SYMBOL(fsl_ifc_ctrl_dev);
> > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > > index f05e0e9..eace3ef 100644
> > > --- a/drivers/mtd/nand/Kconfig
> > > +++ b/drivers/mtd/nand/Kconfig
> > > @@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC
> > >
> > > config MTD_NAND_FSL_IFC
> > > tristate "NAND support for Freescale IFC controller"
> > > - depends on MTD_NAND && FSL_SOC
> > > + depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE)
> > > select FSL_IFC
> > > select MEMORY
> > > help
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape
2016-07-01 16:02 [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape Raghav Dogra
2016-07-04 9:29 ` Boris Brezillon
@ 2016-07-09 1:04 ` Scott Wood
2016-07-14 0:32 ` Brian Norris
1 sibling, 1 reply; 6+ messages in thread
From: Scott Wood @ 2016-07-09 1:04 UTC (permalink / raw)
To: Raghav Dogra, linux-mtd
Cc: boris.brezillon, computersforpeace, leoyang.li,
prabhakar.kushwaha
On Fri, 2016-07-01 at 21:32 +0530, Raghav Dogra wrote:
> This patch enables IFC NAND support on ARM layerscape platform.
> It fixes the dependency to enable NAND. The include files are being modified
> to ensure complilation for both PowerPC and ARM architectures.
>
> Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> ---
> Applicable to git://git.infradead.org/l2-mtd.git
>
> Changes for v2: updated commit description
>
> drivers/memory/Kconfig | 2 +-
> drivers/memory/fsl_ifc.c | 4 +++-
> drivers/mtd/nand/Kconfig | 2 +-
> 3 files changed, 5 insertions(+), 3 deletions(-)
Acked-by: Scott Wood <oss@buserror.net>
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape
2016-07-09 1:04 ` Scott Wood
@ 2016-07-14 0:32 ` Brian Norris
0 siblings, 0 replies; 6+ messages in thread
From: Brian Norris @ 2016-07-14 0:32 UTC (permalink / raw)
To: Scott Wood
Cc: Raghav Dogra, linux-mtd, boris.brezillon, leoyang.li,
prabhakar.kushwaha
On Fri, Jul 08, 2016 at 08:04:05PM -0500, Scott Wood wrote:
> On Fri, 2016-07-01 at 21:32 +0530, Raghav Dogra wrote:
> > This patch enables IFC NAND support on ARM layerscape platform.
> > It fixes the dependency to enable NAND. The include files are being modified
> > to ensure complilation for both PowerPC and ARM architectures.
> >
> > Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> > ---
> > Applicable to git://git.infradead.org/l2-mtd.git
> >
> > Changes for v2: updated commit description
> >
> > drivers/memory/Kconfig | 2 +-
> > drivers/memory/fsl_ifc.c | 4 +++-
> > drivers/mtd/nand/Kconfig | 2 +-
> > 3 files changed, 5 insertions(+), 3 deletions(-)
>
> Acked-by: Scott Wood <oss@buserror.net>
Applied to l2-mtd.git.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-14 0:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-01 16:02 [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape Raghav Dogra
2016-07-04 9:29 ` Boris Brezillon
2016-07-04 9:49 ` Benjamin Herrenschmidt
2016-07-04 9:53 ` Raghav Dogra
2016-07-09 1:04 ` Scott Wood
2016-07-14 0:32 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).