linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: RogerCC.Lin <rogercc.lin@mediatek.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: <xiaolei.li@mediatek.com>, <steven.liu@mediatek.com>,
	<robh@kernel.org>, <computersforpeace@gmail.com>,
	<daniel.thompson@linaro.org>, <linux-mtd@lists.infradead.org>,
	<matthias.bgg@gmail.com>, <linux-mediatek@lists.infradead.org>,
	<dwmw2@infradead.org>, <blogic@openwrt.org>,
	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Subject: [PATCH v2 2/2] mtd: nand: fix chances to create incomplete ECC data when writing.
Date: Mon, 29 Aug 2016 19:40:09 +0800	[thread overview]
Message-ID: <1472470809.11041.6.camel@mtkswgap22> (raw)
In-Reply-To: <20160829101006.2b200e0a@bbrezillon>

When mtk_nfc_do_write_page() comparing the sector number,because the
sector number field is at the 12th-bit position of NFI_BYTELEN
register,the masked register should be shifted 12 bits before being
compared.The result of this bug may cause the second subpage has
incomplete ECC parity bytes.

Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com>
---
 drivers/mtd/nand/mtk_nand.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/nand/mtk_nand.c b/drivers/mtd/nand/mtk_nand.c
index ddaa2ac..5e0727c 100644
--- a/drivers/mtd/nand/mtk_nand.c
+++ b/drivers/mtd/nand/mtk_nand.c
@@ -699,8 +699,8 @@ static int mtk_nfc_do_write_page(struct mtd_info
*mtd, struct nand_chip *chip,
 	}
 
 	ret = readl_poll_timeout_atomic(nfc->regs + NFI_ADDRCNTR, reg,
-					(reg & CNTR_MASK) >= chip->ecc.steps,
-					10, MTK_TIMEOUT);
+			  ((reg & CNTR_MASK) >> 12) >= chip->ecc.steps,
+			  10, MTK_TIMEOUT);
 	if (ret)
 		dev_err(dev, "hwecc write timeout\n");
 
@@ -902,8 +902,8 @@ static int mtk_nfc_read_subpage(struct mtd_info
*mtd, struct nand_chip *chip,
 		dev_warn(nfc->dev, "read ahb/dma done timeout\n");
 
 	rc = readl_poll_timeout_atomic(nfc->regs + NFI_BYTELEN, reg,
-				       (reg & CNTR_MASK) >= sectors, 10,
-				       MTK_TIMEOUT);
+				       ((reg & CNTR_MASK) >> 12) >= sectors, 
+				       10, MTK_TIMEOUT);
 	if (rc < 0) {
 		dev_err(nfc->dev, "subpage done timeout\n");
 		bitflips = -EIO;
--
1.7.0.4

      parent reply	other threads:[~2016-08-29 11:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29  3:58 [Patch] mtd: fix writing incorrect ECC parity data in OOB region mtk04561
2016-08-29  8:10 ` Boris Brezillon
2016-08-29  8:56   ` Jorge Ramirez
2016-08-29 11:40   ` [PATCH v2 0/2] mtd: nand: " RogerCC.Lin
2016-08-29 11:53     ` RogerCC.Lin
2016-08-29 11:40   ` [PATCH v2 1/2] mtd: nand: fix generating over-boundary ECC data when writing RogerCC.Lin
2016-08-29 11:40   ` RogerCC.Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472470809.11041.6.camel@mtkswgap22 \
    --to=rogercc.lin@mediatek.com \
    --cc=blogic@openwrt.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dwmw2@infradead.org \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    --cc=steven.liu@mediatek.com \
    --cc=xiaolei.li@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).