From: Artem Bityutskiy <dedekind1@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Mason <slash.tmp@free.fr>
Cc: Sebastian Frias <sf84@laposte.net>,
Richard Weinberger <richard@nod.at>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Jean-Baptiste Lescher <jblescher@gmail.com>,
Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Subject: Re: [PATCH v5] mtd: nand: tango: import driver for tango chips
Date: Tue, 20 Sep 2016 10:39:56 +0300 [thread overview]
Message-ID: <1474357196.2342.573.camel@gmail.com> (raw)
In-Reply-To: <20160920092441.1f9fa21e@bbrezillon>
On Tue, 2016-09-20 at 09:24 +0200, Boris Brezillon wrote:
> > >> + writel_relaxed(chip->timing1, nfc->reg_base + NFC_TIMING1);
> > >> + writel_relaxed(chip->timing2, nfc->reg_base + NFC_TIMING2);
> > >> + writel_relaxed(chip->xfer_cfg, nfc->reg_base + NFC_XFER_CFG);
> > >> + writel_relaxed(chip->pkt_0_cfg, nfc->reg_base + NFC_PKT_0_CFG);
> > >> + writel_relaxed(chip->pkt_n_cfg, nfc->reg_base + NFC_PKT_N_CFG);
> > >> + writel_relaxed(chip->bb_cfg, nfc->reg_base + NFC_BB_CFG);
> > >
> > > Nit: can you avoid these weird alignments. Use a single space after the
> > > comma.
> >
> > I was trying to highlight the fact that all these writes are
> > within the reg_base area. I'll do as you ask, since you are
> > the gatekeeper.
>
> Is that really less clear without the tabs?
Visually the aligned stuff looks nicer, and some kernel maintainers
prefer this style. Other maintainers avoid it because it causes more
churn. Indeed, imaging you need to add another field with longer name,
or one of the existing fields is renamed - then you need to re-align,
your patches become larger.
So my suggestion is to just follow maintainers' preferences.
next prev parent reply other threads:[~2016-09-20 7:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 10:02 [PATCH v1] mtd: nand: tango: import driver for tango controller Marc Gonzalez
2016-09-05 7:14 ` Boris Brezillon
2016-09-05 10:18 ` Mason
2016-09-05 11:15 ` Boris Brezillon
2016-09-08 15:55 ` [PATCH v2] mtd: nand: tango: import driver for tango chips Marc Gonzalez
2016-09-08 16:37 ` Marc Gonzalez
2016-09-09 16:13 ` [PATCH v3] " Marc Gonzalez
2016-09-11 12:50 ` Mason
2016-09-12 19:08 ` Boris Brezillon
2016-09-19 13:12 ` [PATCH v5] " Marc Gonzalez
2016-09-19 15:57 ` Marc Gonzalez
2016-09-19 17:06 ` Boris Brezillon
2016-09-19 22:37 ` Mason
2016-09-20 7:24 ` Boris Brezillon
2016-09-20 7:39 ` Artem Bityutskiy [this message]
2016-09-20 7:57 ` Richard Weinberger
2016-09-21 16:45 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474357196.2342.573.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=jblescher@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=richard@nod.at \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
--cc=thibaud_cornic@sigmadesigns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).