From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from conuserg-11.nifty.com ([210.131.2.78]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cAhNm-00050q-Qf for linux-mtd@lists.infradead.org; Sat, 26 Nov 2016 18:07:31 +0000 From: Masahiro Yamada To: linux-mtd@lists.infradead.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org, Boris Brezillon , Marek Vasut , Brian Norris , Richard Weinberger , David Woodhouse , Cyrille Pitchen Subject: [PATCH 09/39] mtd: nand: denali: fix erased page check code Date: Sun, 27 Nov 2016 03:05:55 +0900 Message-Id: <1480183585-592-10-git-send-email-yamada.masahiro@socionext.com> In-Reply-To: <1480183585-592-1-git-send-email-yamada.masahiro@socionext.com> References: <1480183585-592-1-git-send-email-yamada.masahiro@socionext.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Currently, is_erased() is called against "buf" twice, so the second call is meaningless. The second one should be checked against chip->oob_poi. Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/denali.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index cbc7f75..753e9a02 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1160,7 +1160,7 @@ static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip, if (check_erased_page) { if (!is_erased(buf, mtd->writesize)) mtd->ecc_stats.failed++; - if (!is_erased(buf, mtd->oobsize)) + if (!is_erased(chip->oob_poi, mtd->oobsize)) mtd->ecc_stats.failed++; } } -- 2.7.4