From: Philip Rakity <prakity@yahoo.com>
To: linux-mtd@lists.infradead.org
Subject: PATCH - add cmdline partition support to cafe (eg mtdparts= boot command)
Date: Wed, 1 Oct 2008 14:00:51 -0700 (PDT) [thread overview]
Message-ID: <148191.46055.qm@web58908.mail.re1.yahoo.com> (raw)
Folks,
Could we please incorporate this info the main line linux code. Adds command line mtdparts= support for cafe_nand flash.
NOTE: I changed where add_mtd_device was done so that there is NOT a complete flash mount point following by the partitions that were added. Before this n+1 partitions were added. 1 partition for the complete flash and then n partitions.
Philip
--- cafe_nand.c.ORIGINAL 2008-10-01 13:53:11.000000000 -0700
+++ cafe_nand.c 2008-10-01 13:55:01.000000000 -0700
@@ -87,8 +87,12 @@
module_param_array(timing, int, &numtimings, 0644);
#ifdef CONFIG_MTD_PARTITIONS
+#ifdef CONFIG_MTD_CMDLINE_PARTS
+static const char *part_probes[] = { "cmdlinepart", "RedBoot", NULL };
+#else
static const char *part_probes[] = { "RedBoot", NULL };
#endif
+#endif
/* Hrm. Why isn't this already conditional on something in the struct device? */
#define cafe_dev_dbg(dev, args...) do { if (debug) dev_dbg(dev, ##args); } while(0)
@@ -628,7 +632,7 @@
struct cafe_priv *cafe;
struct mtd_partition *parts;
uint32_t ctrl;
- int nr_parts;
+ int nr_parts = 0;
int err = 0;
/* Very old versions shared the same PCI ident for all three
@@ -796,17 +800,21 @@
pci_set_drvdata(pdev, mtd);
- /* We register the whole device first, separate from the partitions */
- add_mtd_device(mtd);
-
#ifdef CONFIG_MTD_PARTITIONS
+#ifdef CONFIG_MTD_CMDLINE_PARTS
+ mtd->name = "cafe_nand";
+#endif
nr_parts = parse_mtd_partitions(mtd, part_probes, &parts, 0);
if (nr_parts > 0) {
cafe->parts = parts;
- dev_info(&cafe->pdev->dev, "%d RedBoot partitions found\n", nr_parts);
+ dev_info(&cafe->pdev->dev, "%d partitions found\n", nr_parts);
add_mtd_partitions(mtd, parts, nr_parts);
}
#endif
+
+ /* We register the whole device first, separate from the partitions */
+ if (nr_parts <= 0)
+ add_mtd_device(mtd);
goto out;
Signed off by Philip Rakity -- October 1, 2008
next reply other threads:[~2008-10-01 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 21:00 Philip Rakity [this message]
2008-10-08 12:34 ` PATCH - add cmdline partition support to cafe (eg mtdparts= boot command) Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148191.46055.qm@web58908.mail.re1.yahoo.com \
--to=prakity@yahoo.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox