Re: [PATCH 2/3] dt-bindings: mtd: add a common label property to all mtd devices

Boris Brezillon
2017-01-16T13:53:21Z

On Mon, 16 Jan 2017 14:27:04 +0100
Cédric Le Goater <clg@kaod.org> wrote:

> This can be used to easily identify a specific chip on a system with
> multiple chips.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> Documentation/devicetree/bindings/mtd/common.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/common.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/common.txt b/Documentation/devicetree/bindings/mtd/common.txt
> new file mode 100644
> index 000000000000..a781641a3b00
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/common.txt
> @@ -0,0 +1,12 @@
> +* Common properties of all MTD devices
> +
> +Optional properties:
> +- label : name to assign to mtd. If omitted, the label is the MTD device name.

Hm, the description is not really clear. How about:

"
- label: user-defined MTD device name. Can be used to assign user
friendly names to MTD devices (instead of the flash model or flash
controller based name) in order to ease flash device identification
and/or describe what they are used for.
"

Otherwise,

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks,

Boris

> +
> +Example:
> +
> + flash@0 {
> + label = "System-firmware";
> +
> + /* flash type specific properties */
> + };