From: Logan Gunthorpe <logang@deltatee.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Johannes Thumshirn <jthumshirn@suse.de>, Jan Kara <jack@suse.cz>,
Arnd Bergmann <arnd@arndb.de>,
Sajjan Vikas C <vikas.cha.sajjan@hpe.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Olof Johansson <olof@lixom.net>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Haggai Eran <haggaie@mellanox.com>,
Parav Pandit <pandit.parav@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Matt Porter <mporter@kernel.crashing.org>,
Alexandre Bounine <alexandre.bounine@idt.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Boaz Harrosh <ooo@electrozaur.com>,
Benny Halevy <bhalevy@primarydata.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stephen Bates <stephen.bates@microsemi.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, osd-dev@open-osd.org,
linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com,
linux-mtd@lists.infradead.org, linux-media@vger.kernel.org,
linux-iio@vger.kernel.org, linux-rdma@vger.kernel.org,
tpmdd-devel@lists.sourceforge.net, linux-gpio@vger.kernel.org,
linux-input@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH 03/14] input: utilize new device_add_cdev helper function
Date: Mon, 20 Feb 2017 22:00:42 -0700 [thread overview]
Message-ID: <1487653253-11497-4-git-send-email-logang@deltatee.com> (raw)
In-Reply-To: <1487653253-11497-1-git-send-email-logang@deltatee.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
---
drivers/input/evdev.c | 3 +--
drivers/input/joydev.c | 3 +--
drivers/input/mousedev.c | 3 +--
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index e9ae3d5..a3407ea 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -1416,8 +1416,7 @@ static int evdev_connect(struct input_handler *handler, struct input_dev *dev,
goto err_free_evdev;
cdev_init(&evdev->cdev, &evdev_fops);
- evdev->cdev.kobj.parent = &evdev->dev.kobj;
- error = cdev_add(&evdev->cdev, evdev->dev.devt, 1);
+ error = device_add_cdev(&evdev->dev, &evdev->cdev);
if (error)
goto err_unregister_handle;
diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c
index abd18f3..012e06f 100644
--- a/drivers/input/joydev.c
+++ b/drivers/input/joydev.c
@@ -905,8 +905,7 @@ static int joydev_connect(struct input_handler *handler, struct input_dev *dev,
goto err_free_joydev;
cdev_init(&joydev->cdev, &joydev_fops);
- joydev->cdev.kobj.parent = &joydev->dev.kobj;
- error = cdev_add(&joydev->cdev, joydev->dev.devt, 1);
+ error = device_add_cdev(&joydev->dev, &joydev->cdev);
if (error)
goto err_unregister_handle;
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index b604564..efd8666 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -901,8 +901,7 @@ static struct mousedev *mousedev_create(struct input_dev *dev,
}
cdev_init(&mousedev->cdev, &mousedev_fops);
- mousedev->cdev.kobj.parent = &mousedev->dev.kobj;
- error = cdev_add(&mousedev->cdev, mousedev->dev.devt, 1);
+ error = device_add_cdev(&mousedev->dev, &mousedev->cdev);
if (error)
goto err_unregister_handle;
--
2.1.4
next prev parent reply other threads:[~2017-02-21 5:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 5:00 [PATCH 00/14] Cleanup chardev instances with helper function Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 01/14] chardev: add helper function to register char devs with a struct device Logan Gunthorpe
2017-02-21 5:35 ` Dmitry Torokhov
2017-02-21 6:35 ` Logan Gunthorpe
2017-02-21 18:18 ` Dan Williams
2017-02-21 23:41 ` Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 02/14] device-dax: utilize new device_add_cdev helper function Logan Gunthorpe
2017-02-21 11:37 ` Alexandre Belloni
2017-02-21 19:26 ` Dan Williams
2017-02-21 5:00 ` Logan Gunthorpe [this message]
2017-02-23 8:37 ` [PATCH 03/14] input: " Dmitry Torokhov
2017-02-21 5:00 ` [PATCH 04/14] gpiolib: " Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 05/14] tpm-chip: " Logan Gunthorpe
2017-02-21 18:39 ` Jason Gunthorpe
2017-02-21 5:00 ` [PATCH 06/14] platform/chrome: " Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 07/14] infiniband: " Logan Gunthorpe
2017-02-21 19:09 ` Jason Gunthorpe
2017-02-21 23:54 ` Logan Gunthorpe
2017-02-22 0:48 ` Jason Gunthorpe
2017-02-22 8:18 ` Lars-Peter Clausen
2017-02-21 5:00 ` [PATCH 08/14] iio:core: " Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 09/14] media: " Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 10/14] mtd: " Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 11/14] rapidio: " Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 12/14] rtc: " Logan Gunthorpe
2017-02-21 5:00 ` [PATCH 13/14] scsi: " Logan Gunthorpe
2017-02-21 12:52 ` Boaz Harrosh
2017-02-21 5:00 ` [PATCH 14/14] switchtec: " Logan Gunthorpe
2017-02-21 7:54 ` [PATCH 00/14] Cleanup chardev instances with " Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487653253-11497-4-git-send-email-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=alexandre.bounine@idt.com \
--cc=arnd@arndb.de \
--cc=bhalevy@primarydata.com \
--cc=bhelgaas@google.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dan.j.williams@intel.com \
--cc=dedekind1@gmail.com \
--cc=dledford@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dvyukov@google.com \
--cc=dwmw2@infradead.org \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haggaie@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=jack@suse.cz \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=jthumshirn@suse.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=leon@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=mchehab@kernel.org \
--cc=mporter@kernel.crashing.org \
--cc=olof@lixom.net \
--cc=ooo@electrozaur.com \
--cc=osd-dev@open-osd.org \
--cc=pandit.parav@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=pmeerw@pmeerw.net \
--cc=richard@nod.at \
--cc=rtc-linux@googlegroups.com \
--cc=sean.hefty@intel.com \
--cc=stephen.bates@microsemi.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=vikas.cha.sajjan@hpe.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox