Re: [PATCH 01/10] mtd: spi-nor: aspeed: fix the AST2400 SMC window size

Marek Vasut
2017-04-06T19:17:55Z

On 04/06/2017 06:56 PM, Cédric Le Goater wrote:
> The window of the Aspeed AST2400 SMC Controller to map chips on the
> AHB Bus has a 256MB size. 64MB is the default size for the first chip
> select and not the full window range: [ 0x20000000 - 0x2FFFFFFF ].
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> drivers/mtd/spi-nor/aspeed-smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
> index 56051d30f000..aa2c647c8507 100644
> --- a/drivers/mtd/spi-nor/aspeed-smc.c
> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
> @@ -48,7 +48,7 @@ static void aspeed_smc_chip_set_4b_spi_2400(struct aspeed_smc_chip *chip);
> static void aspeed_smc_chip_set_4b(struct aspeed_smc_chip *chip);
>
> static const struct aspeed_smc_info fmc_2400_info = {
> - .maxsize = 64 * 1024 * 1024,
> + .maxsize = 256 * 1024 * 1024,

How does the second part of reg property in DT relate to this ?
DT binding example has it set to 0x02000000 = 32 MiB ...

> .nce = 5,
> .hastype = true,
> .we0 = 16,
>

--
Best regards,
Marek Vasut