From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Marek Vasut" <marek.vasut@gmail.com>,
"Cédric Le Goater" <clg@kaod.org>,
linux-mtd@lists.infradead.org
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH 10/10] mtd: spi-nor: aspeed: optimize read mode
Date: Sat, 15 Apr 2017 07:40:32 +1000 [thread overview]
Message-ID: <1492206032.25766.7.camel@kernel.crashing.org> (raw)
In-Reply-To: <6f7f424c-2a3f-4b6d-f7aa-bfae749de0b3@gmail.com>
On Fri, 2017-04-14 at 18:18 +0200, Marek Vasut wrote:
> > Here is a proposal. We could activate this algo using a property such
> > as :
> >
> > "speed-mode" = "freq" or "auto-adjust"
> >
> > How's that ?
>
> Thinking about it a bit more, I think having a module parameter is the
> right approach here ... or maybe compile-time switch. This shouldn't be
> in DT as it's not HW property.
Strong disagreement here :-)
DT is not *strictly* HW properties. Never was despite what some
fanatics around might say :-) Its also platform properties and can
include policies.
We put things like UART speeds in there, MAC addresses, etc... it makes
sense to put calibration info and in this case, request to perform SW
calibration.
Module parameters are crap. They are a major pain to use, they are in
practice only good for tweaking/experimenting.
Ben.
next prev parent reply other threads:[~2017-04-14 21:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 16:56 [PATCH 00/10] mtd: spi-nor: aspeed: support extensions Cédric Le Goater
2017-04-06 16:56 ` [PATCH 01/10] mtd: spi-nor: aspeed: fix the AST2400 SMC window size Cédric Le Goater
2017-04-06 19:17 ` Marek Vasut
2017-04-11 10:18 ` Cédric Le Goater
2017-04-11 10:42 ` Marek Vasut
2017-04-11 16:10 ` Cédric Le Goater
2017-04-06 16:56 ` [PATCH 02/10] mtd: spi-nor: aspeed: remove dummies from keep mask Cédric Le Goater
2017-04-06 16:56 ` [PATCH 03/10] mtd: spi-nor: aspeed: add DMA support Cédric Le Goater
2017-04-06 19:07 ` Cyrille Pitchen
2017-04-06 19:13 ` Cyrille Pitchen
2017-04-19 14:36 ` Cédric Le Goater
2017-04-06 16:56 ` [PATCH 04/10] mtd: spi-nor: aspeed: add support for SPI dual IO read mode Cédric Le Goater
2017-04-06 19:21 ` Marek Vasut
2017-04-11 8:53 ` Cédric Le Goater
2017-04-11 10:43 ` Marek Vasut
2017-04-06 16:56 ` [PATCH 05/10] mtd: spi-nor: Add support for Macronix mx66l1g45g spi flash Cédric Le Goater
2017-04-06 19:21 ` Marek Vasut
2017-04-06 16:56 ` [PATCH 06/10] mtd: spi-nor: add SPI_NOR_DUAL_READ to some flash devices Cédric Le Goater
2017-04-06 19:22 ` Marek Vasut
2017-04-11 8:15 ` Cédric Le Goater
2017-04-06 16:56 ` [PATCH 07/10] mtd: spi-nor: aspeed: configure chip window on AHB bus Cédric Le Goater
2017-04-06 19:25 ` Marek Vasut
2017-04-11 10:20 ` Cédric Le Goater
2017-04-11 10:44 ` Marek Vasut
2017-04-06 16:56 ` [PATCH 08/10] mtd: spi-nor: aspeed: use command mode for reads Cédric Le Goater
2017-04-06 16:56 ` [PATCH 09/10] mtd: spi-nor: aspeed: link controller with the ahb clock Cédric Le Goater
2017-04-06 16:56 ` [PATCH 10/10] mtd: spi-nor: aspeed: optimize read mode Cédric Le Goater
2017-04-06 19:28 ` Marek Vasut
2017-04-11 8:13 ` Cédric Le Goater
2017-04-11 8:23 ` Benjamin Herrenschmidt
2017-04-14 16:18 ` Marek Vasut
2017-04-14 21:40 ` Benjamin Herrenschmidt [this message]
2017-04-14 21:51 ` Marek Vasut
2017-04-14 22:11 ` Benjamin Herrenschmidt
2017-04-14 22:25 ` Marek Vasut
2017-04-14 22:42 ` Benjamin Herrenschmidt
2017-04-16 18:46 ` Marek Vasut
2017-04-18 15:46 ` Cédric Le Goater
2017-04-18 16:51 ` Marek Vasut
2017-04-18 22:41 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492206032.25766.7.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=boris.brezillon@free-electrons.com \
--cc=clg@kaod.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=joel@jms.id.au \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox