From: David Woodhouse <dwmw2@infradead.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-mtd@lists.infradead.org
Cc: cphealy@gmail.com, Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their kernel counterparts
Date: Wed, 19 Apr 2017 16:35:12 +0100 [thread overview]
Message-ID: <1492616112.17682.266.camel@infradead.org> (raw)
In-Reply-To: <20170419152305.17226-1-andrew.smirnov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Wed, 2017-04-19 at 08:23 -0700, Andrey Smirnov wrote:
> No functional change intended.
FWIW I *deliberately* used the proper C datatypes throughout all of the
MTD code instead of the silly kernel-speshul datatypes. To the extent
of *fixing* submissions to be written in C when they were using the
silly kernel types instead.
There is a reason for the __u32 type in userspace APIs. There is
basically no reason for 'u32' et al, just to save a trivial few
characters in the type name. We might as well be using the proper
language types.
I appreciate that not everyone agrees with that, but at least it used
to be consistent throughout the code I was maintaining. I'll defer to
the currently active maintainers though...
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]
next prev parent reply other threads:[~2017-04-19 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 15:23 [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their kernel counterparts Andrey Smirnov
2017-04-19 15:23 ` [PATCH v3 2/6] mtd: dataflash: Improve coding style in jedec_probe() Andrey Smirnov
2017-04-19 15:23 ` [PATCH v3 3/6] mtd: dataflash: Replace pr_debug, printk with dev_* functions Andrey Smirnov
2017-04-19 15:33 ` Marek Vasut
2017-04-19 15:50 ` Andrey Smirnov
2017-04-19 16:13 ` Marek Vasut
2017-04-19 15:23 ` [PATCH v3 4/6] mtd: dataflash: Get rid of loop counter in jedec_probe() Andrey Smirnov
2017-04-19 15:34 ` Marek Vasut
2017-04-19 15:23 ` [PATCH v3 5/6] mtd: dataflash: Make use of "extened device information" Andrey Smirnov
2017-04-19 15:42 ` Marek Vasut
2017-04-19 16:01 ` Andrey Smirnov
2017-04-19 16:08 ` Marek Vasut
2017-04-19 16:12 ` Marek Vasut
2017-04-19 15:23 ` [PATCH v3 6/6] mtd: dataflash: Add flash_info for AT45DB641E Andrey Smirnov
2017-04-19 15:35 ` David Woodhouse [this message]
2017-04-19 16:04 ` [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their kernel counterparts Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492616112.17682.266.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=andrew.smirnov@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cphealy@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox