From: "Cédric Le Goater" <clg@kaod.org>
To: linux-mtd@lists.infradead.org
Cc: "Cyrille Pitchen" <cyrille.pitchen@atmel.com>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Richard Weinberger" <richard@nod.at>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH 1/4] mtd: spi-nor: aspeed: remove dummies from keep mask
Date: Thu, 20 Apr 2017 13:56:34 +0200 [thread overview]
Message-ID: <1492689397-4704-2-git-send-email-clg@kaod.org> (raw)
In-Reply-To: <1492689397-4704-1-git-send-email-clg@kaod.org>
There is no need to keep the dummy bytes in the control register if
the command mode is not kept also. This could lead to an inconsistent
setting : normal read mode (command 0x3) and dummy bytes. It is to be
noted that the HW allows such a configuration.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
drivers/mtd/spi-nor/aspeed-smc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
index 56051d30f000..2940f2098420 100644
--- a/drivers/mtd/spi-nor/aspeed-smc.c
+++ b/drivers/mtd/spi-nor/aspeed-smc.c
@@ -180,8 +180,7 @@ struct aspeed_smc_controller {
#define CONTROL_KEEP_MASK \
(CONTROL_AAF_MODE | CONTROL_CE_INACTIVE_MASK | CONTROL_CLK_DIV4 | \
- CONTROL_IO_DUMMY_MASK | CONTROL_CLOCK_FREQ_SEL_MASK | \
- CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3)
+ CONTROL_CLOCK_FREQ_SEL_MASK | CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3)
/*
* The Segment Register uses a 8MB unit to encode the start address
--
2.7.4
next prev parent reply other threads:[~2017-04-20 11:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 11:56 [PATCH 0/4] mtd: spi-nor: aspeed: add dual read and command mode support Cédric Le Goater
2017-04-20 11:56 ` Cédric Le Goater [this message]
2017-04-20 13:28 ` [PATCH 1/4] mtd: spi-nor: aspeed: remove dummies from keep mask Marek Vasut
2017-06-20 22:25 ` Cyrille Pitchen
2017-04-20 11:56 ` [PATCH 2/4] mtd: spi-nor: aspeed: add support for SPI dual IO read mode Cédric Le Goater
2017-04-20 13:28 ` Marek Vasut
2017-06-20 22:50 ` Cyrille Pitchen
2017-06-21 7:32 ` Cédric Le Goater
2017-06-21 12:25 ` Cédric Le Goater
2017-06-21 22:46 ` Cyrille Pitchen
2017-04-20 11:56 ` [PATCH 3/4] mtd: spi-nor: aspeed: configure chip window on AHB bus Cédric Le Goater
2017-04-20 13:30 ` Marek Vasut
2017-06-20 22:34 ` Cyrille Pitchen
2017-04-20 11:56 ` [PATCH 4/4] mtd: spi-nor: aspeed: use command mode for reads Cédric Le Goater
2017-04-20 13:31 ` Marek Vasut
2017-04-20 13:33 ` Richard Weinberger
2017-04-20 13:53 ` Cédric Le Goater
2017-04-20 13:58 ` Marek Vasut
2017-06-20 7:10 ` Cédric Le Goater
2017-06-20 9:07 ` Cédric Le Goater
[not found] ` <2bd0b105-7652-8917-4a1d-6f218eaf848e@atmel.com>
2017-06-20 13:49 ` Cédric Le Goater
2017-06-20 14:06 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492689397-4704-2-git-send-email-clg@kaod.org \
--to=clg@kaod.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox