From: Fabio Estevam <festevam@gmail.com>
To: han.xu@nxp.com
Cc: cyrille.pitchen@wedev4u.fr, david.wolfe@nxp.com,
frank.li@nxp.com, linux-mtd@lists.infradead.org,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: [PATCH] mtd: fsl-quadspi: Distinguish the mtd device names
Date: Fri, 5 Jan 2018 17:46:00 -0200 [thread overview]
Message-ID: <1515181560-1410-1-git-send-email-festevam@gmail.com> (raw)
From: Fabio Estevam <fabio.estevam@nxp.com>
Currently on a imx6sx-sdb board, which has two SPI NOR chips connected
to QSPI2 the following output from /proc/mtd is seen:
# cat /proc/mtd
dev: size erasesize name
mtd0: 01000000 00010000 "21e4000.qspi"
mtd1: 01000000 00010000 "21e4000.qspi"
Attempts to partition them on the kernel command line result in both
chips with identical (and identically named) partitions, which is
an inconvenient behavior.
Assign a different mtd->name for each mtd device to avoid this problem.
After this change the output from /proc/mtd becomes:
# cat /proc/mtd
dev: size erasesize name
mtd0: 01000000 00010000 "fsl-quadspi.0"
mtd1: 01000000 00010000 "fsl-quadspi.1"
Reported-by: David Wolfe <david.wolfe@nxp.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/mtd/spi-nor/fsl-quadspi.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index f17d224..7712c63 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -967,7 +967,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
struct resource *res;
struct spi_nor *nor;
struct mtd_info *mtd;
- int ret, i = 0;
+ int ret, i = 0, mtd_index = 0;
q = devm_kzalloc(dev, sizeof(*q), GFP_KERNEL);
if (!q)
@@ -1047,6 +1047,13 @@ static int fsl_qspi_probe(struct platform_device *pdev)
nor = &q->nor[i];
mtd = &nor->mtd;
+ mtd->name = devm_kasprintf(dev, GFP_KERNEL, "fsl-quadspi.%d",
+ mtd_index);
+ if (!mtd->name) {
+ ret = -ENOMEM;
+ goto mutex_failed;
+ }
+
nor->dev = dev;
spi_nor_set_flash_node(nor, np);
nor->priv = q;
@@ -1098,6 +1105,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
nor->page_size = q->devtype_data->txfifo;
i++;
+ mtd_index++;
}
/* finish the rest init. */
--
2.7.4
next reply other threads:[~2018-01-05 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 19:46 Fabio Estevam [this message]
2018-01-08 17:13 ` [PATCH] mtd: fsl-quadspi: Distinguish the mtd device names Han Xu
2018-01-10 22:17 ` Boris Brezillon
2018-01-10 22:39 ` Fabio Estevam
2018-01-10 22:42 ` Boris Brezillon
2018-01-10 22:54 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515181560-1410-1-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=david.wolfe@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=frank.li@nxp.com \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox