From: Joe Perches <joe@perches.com>
To: Arushi Singhal <arushisinghal19971997@gmail.com>, dwmw2@infradead.org
Cc: Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: chips: Replace printk() with pr_*() and define pr_fmt()
Date: Mon, 12 Mar 2018 10:25:36 -0700 [thread overview]
Message-ID: <1520875536.2049.11.camel@perches.com> (raw)
In-Reply-To: <20180312170208.GA10604@seema-Inspiron-15-3567>
On Mon, 2018-03-12 at 22:32 +0530, Arushi Singhal wrote:
> Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
> This patch:
> * Replace printks having a log level with the appropriate pr_*() macros.
> * Define pr_fmt() to include relevant name.
> * Remove redundant prefixes from pr_*() calls.
> * Indent the code where possible.
Hello Arushi.
When you do these, please remember to remove the unnecessary
and inconsistent uses of periods and to coalesce formats
where appropriate.
Also, there was _some_ logic here behind the use of the
"cfi_cmdset_0001:" prefix on only some of the error messages.
Perhaps the commit message should describe that change a bit
more fully.
Lastly, please run checkpatch on your proposed patches.
$ ./scripts/checkpatch.pl --terse patch.mbox
patch.mbox:151: ERROR: space prohibited before that close parenthesis ')'
patch.mbox:160: ERROR: space prohibited before that close parenthesis ')'
patch.mbox:183: WARNING: line over 80 characters
patch.mbox:201: WARNING: line over 80 characters
patch.mbox:211: ERROR: space required after that ',' (ctx:VxV)
patch.mbox:253: WARNING: quoted string split across lines
patch.mbox:273: WARNING: line over 80 characters
patch.mbox:273: WARNING: Prefer using '"%s...", __func__' to using 'put_chip', this function's name, in a string
patch.mbox:282: WARNING: line over 80 characters
patch.mbox:304: WARNING: line over 80 characters
patch.mbox:313: WARNING: line over 80 characters
patch.mbox:346: WARNING: line over 80 characters
patch.mbox:364: WARNING: line over 80 characters
patch.mbox:376: WARNING: line over 80 characters
patch.mbox:383: WARNING: line over 80 characters
patch.mbox:456: WARNING: line over 80 characters
patch.mbox:465: WARNING: line over 80 characters
total: 3 errors, 14 warnings, 343 lines checked
next prev parent reply other threads:[~2018-03-12 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 17:02 [PATCH] mtd: chips: Replace printk() with pr_*() and define pr_fmt() Arushi Singhal
2018-03-12 17:25 ` Joe Perches [this message]
2018-03-13 16:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520875536.2049.11.camel@perches.com \
--to=joe@perches.com \
--cc=arushisinghal19971997@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox