From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Antonio Cardace <anto.cardace@gmail.com>,
boris.brezillon@free-electrons.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nftl: use %*ph to print small buffer
Date: Fri, 16 Mar 2018 16:20:30 +0200 [thread overview]
Message-ID: <1521210030.23017.15.camel@linux.intel.com> (raw)
In-Reply-To: <20180213175245.17703-1-anto.cardace@gmail.com>
On Tue, 2018-02-13 at 17:52 +0000, Antonio Cardace wrote:
> Use %*ph format to print small buffer as hex string.
>
Any comments so far?
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Antonio Cardace <anto.cardace@gmail.com>
> ---
>
> drivers/mtd/nftlmount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
> index 184c8fbfe465..a8bdc1455b50 100644
> --- a/drivers/mtd/nftlmount.c
> +++ b/drivers/mtd/nftlmount.c
> @@ -122,8 +122,7 @@ static int find_boot_record(struct NFTLrecord
> *nftl)
> if (memcmp(buf, "ANAND", 6)) {
> printk(KERN_NOTICE "ANAND header found at
> 0x%x in mtd%d, but went away on reread!\n",
> block * nftl->EraseSize, nftl-
> >mbd.mtd->index);
> - printk(KERN_NOTICE "New data are: %02x %02x
> %02x %02x %02x %02x\n",
> - buf[0], buf[1], buf[2], buf[3],
> buf[4], buf[5]);
> + printk(KERN_NOTICE "New data are: %6ph\n",
> buf);
> continue;
> }
> #endif
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-03-16 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 17:52 [PATCH] mtd: nftl: use %*ph to print small buffer Antonio Cardace
2018-03-16 14:20 ` Andy Shevchenko [this message]
2018-03-18 21:23 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521210030.23017.15.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=anto.cardace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox