From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga07.intel.com ([134.134.136.100])
 by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux))
 id 1ewqE8-0003X6-MF
 for linux-mtd@lists.infradead.org; Fri, 16 Mar 2018 14:21:15 +0000
Message-ID: <1521210046.23017.16.camel@linux.intel.com>
Subject: Re: [PATCH] mtd: st_spi_fsm: use %*ph to print small buffer
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Antonio Cardace <anto.cardace@gmail.com>,
 boris.brezillon@free-electrons.com, cyrille.pitchen@wedev4u.fr
Cc: linux-mtd@lists.infradead.org
Date: Fri, 16 Mar 2018 16:20:46 +0200
In-Reply-To: <20180212184130.10238-1-anto.cardace@gmail.com>
References: <20180212184130.10238-1-anto.cardace@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Mon, 2018-02-12 at 18:41 +0000, Antonio Cardace wrote:
> Use %*ph format to print small buffer as hex string.
> 

Any comments so far?

> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Antonio Cardace <anto.cardace@gmail.com>
> ---
>  drivers/mtd/devices/st_spi_fsm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/devices/st_spi_fsm.c
> b/drivers/mtd/devices/st_spi_fsm.c
> index 7bc29d725200..a33f5fd6818c 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -1868,8 +1868,7 @@ static struct flash_info
> *stfsm_jedec_probe(struct stfsm *fsm)
>  	 */
>  	ext_jedec = id[3] << 8  | id[4];
>  
> -	dev_dbg(fsm->dev, "JEDEC =  0x%08x [%02x %02x %02x %02x
> %02x]\n",
> -		jedec, id[0], id[1], id[2], id[3], id[4]);
> +	dev_dbg(fsm->dev, "JEDEC =  0x%08x [%5ph]\n", jedec, id);
>  
>  	for (info = flash_types; info->name; info++) {
>  		if (info->jedec_id == jedec) {

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy