linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Patch "mtd: cfi_cmdset_0002: Change write buffer to check correct value" has been added to the 4.14-stable tree
@ 2018-07-01 10:08 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2018-07-01 10:08 UTC (permalink / raw)
  To: Joakim.Tjernlund, boris.brezillon, boris.brezillon, chris.packham,
	computersforpeace, cyrille.pitchen, dwmw2, gregkh, ikegami,
	linux-mtd, marek.vasut, richard
  Cc: stable-commits


This is a note to let you know that I've just added the patch titled

    mtd: cfi_cmdset_0002: Change write buffer to check correct value

to the 4.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mtd-cfi_cmdset_0002-change-write-buffer-to-check-correct-value.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From dfeae1073583dc35c33b32150e18b7048bbb37e6 Mon Sep 17 00:00:00 2001
From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Date: Wed, 30 May 2018 18:32:26 +0900
Subject: mtd: cfi_cmdset_0002: Change write buffer to check correct value

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

commit dfeae1073583dc35c33b32150e18b7048bbb37e6 upstream.

For the word write it is checked if the chip has the correct value.
But it is not checked for the write buffer as only checked if ready.
To make sure for the write buffer change to check the value.

It is enough as this patch is only checking the last written word.
Since it is described by data sheets to check the operation status.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
Cc: stable@vger.kernel.org
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/mtd/chips/cfi_cmdset_0002.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1880,7 +1880,7 @@ static int __xipram do_write_buffer(stru
 		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
 			break;
 
-		if (chip_ready(map, adr)) {
+		if (chip_good(map, adr, datum)) {
 			xip_enable(map, chip, adr);
 			goto op_done;
 		}


Patches currently in stable-queue which might be from ikegami@allied-telesis.co.jp are

queue-4.14/mtd-cfi_cmdset_0002-change-erase-functions-to-retry-for-error.patch
queue-4.14/mtd-cfi_cmdset_0002-change-write-buffer-to-check-correct-value.patch
queue-4.14/mips-bcm47xx-enable-74k-core-externalsync-for-pcie-erratum.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-07-01 10:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-01 10:08 Patch "mtd: cfi_cmdset_0002: Change write buffer to check correct value" has been added to the 4.14-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).