From: "Per Förlin" <per.forlin@axis.com>
To: Richard Weinberger <richard@nod.at>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Artem Bityutskiy" <dedekind1@gmail.com>
Subject: Re: [PATCH] UBI: Add volume read and write statistics
Date: Tue, 17 Jul 2018 12:08:51 +0000 [thread overview]
Message-ID: <1531829331815.70807@axis.com> (raw)
In-Reply-To: <1986554.RvkB0gC8kI@blindfold>
> To: Per Förlin
> Cc: linux-mtd@lists.infradead.org; Artem Bityutskiy; Per Förlin
> Subject: Re: [PATCH] UBI: Add volume read and write statistics
>
> Am Dienstag, 17. Juli 2018, 12:30:19 CEST schrieb Per Forlin:
> > Simple read and write statistics.
> > * Bytes read
> > * Bytes written
> > * Number of reads
> > * Number of writes
> >
> > This is useful to find out how the storage is being utilized.
> > For block devices this already exists via /proc/diskstats.
> > The intention of this patch is to add similar stats
> > for UBI as well.
>
> Why on UBI level and not MTD?
In my case I wanted to evaluate the performance per volume. I have one MTD
device with several UBI volumes. It would be sufficient to have it on
an MTD level to see the overall storage usage.
This would still be very helpful for me.
Having it on an MTD level is of course more general.
I wouldn't mind changing the patch to add the stats in mtdcore
for mtd_read() and mtd_write()
In case of MTD block devices the stats will be somewhat redundant with
/proc/diskstats.
Do you think I should update the patch to add MTD stats instead?
next prev parent reply other threads:[~2018-07-17 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 10:30 [PATCH] UBI: Add volume read and write statistics Per Forlin
2018-07-17 10:39 ` Richard Weinberger
2018-07-17 12:08 ` Per Förlin [this message]
2018-07-17 14:34 ` Richard Weinberger
2018-07-17 15:01 ` Per Förlin
2018-07-17 15:06 ` Steve deRosier
2018-07-17 15:10 ` Richard Weinberger
2018-07-18 20:17 ` Per Förlin
2018-07-19 10:18 ` Per Förlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531829331815.70807@axis.com \
--to=per.forlin@axis.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).