Patch to prevent jffs2 from make changes to other filesystems

Patch to prevent jffs2 from make changes to other filesystems

[Bao C. Ha]

I would like to propose the following patch to
temporarily fix the problem of jffs2 making
changes to other filesystems stored on MTD
partitions.

--- scan.c.orig Tue Oct 23 13:35:38 2001
+++ scan.c      Tue Oct 23 13:32:28 2001
@@ -214,7 +214,8 @@
                        noisy_printk(&noise, "jffs2_scan_eraseblock(): Magic
bit
mask 0x%04x not found at 0x%08x: 0x%04x instead\n", JFFS2_MAGIC_BITMASK,
ofs, no
de.magic);
                        DIRTY_SPACE(4);
                        ofs += 4;
-                       continue;
+                       /* continue; */
+                       return -EINVAL;
                }
                /* We seem to have a node of sorts. Check the CRC */
                nodetype = node.nodetype;

Thanks.
Bao

Re: Patch to prevent jffs2 from make changes to other filesystems

[David Woodhouse]

baoha@sensoria.com said:
>  I would like to propose the following patch to temporarily fix the
> problem of jffs2 making changes to other filesystems stored on MTD
> partitions. 

You can't do it like that - you'll get crap on the filesystem sometimes, 
during normal operation. We have logic in there to abort the mount at the 
end, if no valid nodes were found, but other data were. Is that failing or 
are you using an obsolete version?

Line 147 of scan.c should read:
 printk(KERN_NOTICE "Cowardly refusing to erase blocks on filesystem with no valid JFFS2 nodes\n");

Does it? Why doesn't it get triggered?

--
dwmw2

RE: Patch to prevent jffs2 from make changes to other filesystems

[Bao C. Ha]

Hi David,

I am using kernel 2.4.10 and the older mtd stuff.
I have grabbed the newer mtd from cvs and can
confirm that we no longer have the problem.  The
"Cowardly refusing ..." message was triggered with
no damage to the cramfs.

I apologize for the panic.  We will be moving
forward to 2.4.12 to eliminate this type of
problems.

Regards.
Bao

> -----Original Message-----
> From: linux-mtd-admin@lists.infradead.org
> [mailto:linux-mtd-admin@lists.infradead.org]On Behalf Of 
> David Woodhouse
> Sent: Tuesday, October 23, 2001 2:55 PM
> To: Bao C. Ha
> Cc: linux-mtd@lists.infradead.org
> Subject: Re: Patch to prevent jffs2 from make changes to other
> filesystems 
> 
> 
> 
> 
> baoha@sensoria.com said:
> >  I would like to propose the following patch to temporarily fix the
> > problem of jffs2 making changes to other filesystems stored on MTD
> > partitions. 
> 
> You can't do it like that - you'll get crap on the filesystem 
> sometimes, 
> during normal operation. We have logic in there to abort the 
> mount at the 
> end, if no valid nodes were found, but other data were. Is 
> that failing or 
> are you using an obsolete version?
> 
> Line 147 of scan.c should read:
>  printk(KERN_NOTICE "Cowardly refusing to erase blocks on 
> filesystem with no valid JFFS2 nodes\n");
> 
> Does it? Why doesn't it get triggered?
> 
> --
> dwmw2
> 
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>