public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Alexander Dahl <post@lespocky.de>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org
Subject: Re: mtd: nand: atmel: probe of Spansion S34ML02G1 fails
Date: Mon, 31 Jul 2017 08:13:19 +0200	[thread overview]
Message-ID: <16874505.VNammbPfxu@ada> (raw)
In-Reply-To: <20170727212703.724d41fd@bbrezillon>

Hei hei,

Am Donnerstag, 27. Juli 2017, 21:27:03 schrieb Boris Brezillon:
> Did you have time to test with f9ce2eddf176 ("mtd: nand: atmel: Add
> ->setup_data_interface() hooks") reverted? BTW, it's probably simpler
> to just comment out this line [1]

This does not revert cleanly.

> [1]http://elixir.free-electrons.com/linux/v4.13-rc2/source/drivers/mtd
> /nand/atmel/nand-controller.c#L1493

I tried this in atmel_nand_init():

+       /*
        if (nc->mck && nc->caps->ops->setup_data_interface)
                chip->setup_data_interface = atmel_nand_setup_data_interface;
+       */

So this basically skips all those timing init, right? If I do this I get 
the timings which were applied in U-Boot and the NAND-Flash just works.

Greets
Alex

  reply	other threads:[~2017-07-31  6:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25  9:26 mtd: nand: atmel: probe of Spansion S34ML02G1 fails Alexander Dahl
2017-07-25 18:54 ` Boris Brezillon
2017-07-26  8:15   ` Alexander Dahl
2017-07-26 18:33     ` Boris Brezillon
2017-07-26 20:40       ` Alexander Dahl
2017-07-27 19:27         ` Boris Brezillon
2017-07-31  6:13           ` Alexander Dahl [this message]
2017-07-28 13:15       ` Alexander Dahl
2017-07-28 19:13         ` Boris Brezillon
2017-07-31  6:29           ` Alexander Dahl
2017-07-31  7:44             ` Boris Brezillon
2017-07-31  8:41               ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16874505.VNammbPfxu@ada \
    --to=ada@thorsis.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=post@lespocky.de \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox