From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michal Simek <michal.simek@amd.com>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Punnaiah Choudary Kalluri <punnaia@xilinx.com>,
linux-mtd@lists.infradead.org,
Maciej Andrzejewski <maciej.andrzejewski@m-works.net>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v3] mtd: rawnand: arasan: Fix double assertion of chip-select
Date: Thu, 5 Dec 2024 11:43:27 +0100 [thread overview]
Message-ID: <173339519118.766262.18442148583345975205.b4-ty@bootlin.com> (raw)
In-Reply-To: <Z02tOwEHfDsH1Sil@UBUNTU-PF54DSY0>
On Mon, 02 Dec 2024 13:51:07 +0100, Maciej Andrzejewski wrote:
> When two chip-selects are configured in the device tree, and the second is
> a non-native GPIO, both the GPIO-based chip-select and the first native
> chip-select may be asserted simultaneously. This double assertion causes
> incorrect read and write operations.
>
> The issue occurs because when nfc->ncs <= 2, nfc->spare_cs is always
> initialized to 0 due to static initialization. Consequently, when the
> second chip-select (GPIO-based) is selected in anfc_assert_cs(), it is
> detected by anfc_is_gpio_cs(), and nfc->native_cs is assigned the value 0.
> This results in both the GPIO-based chip-select being asserted and the
> NAND controller register receiving 0, erroneously selecting the native
> chip-select.
>
> [...]
Applied to mtd/fixes, thanks!
[1/1] mtd: rawnand: arasan: Fix double assertion of chip-select
Patche(s) will be available within hours on:
mtd/linux.git
Kind regards,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2024-12-05 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 12:51 [PATCH v3] mtd: rawnand: arasan: Fix double assertion of chip-select Maciej Andrzejewski
2024-12-05 10:43 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173339519118.766262.18442148583345975205.b4-ty@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=linux-mtd@lists.infradead.org \
--cc=maciej.andrzejewski@m-works.net \
--cc=michal.simek@amd.com \
--cc=punnaia@xilinx.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox