Re: [PATCH v3 0/3] Read MAC Address from SST vendor specific SFDP region

From: "Rob Herring (Arm)" <robh@kernel.org>
To: Manikandan Muralidharan <manikandan.m@microchip.com>
Cc: linux-mtd@lists.infradead.org, pratyush@kernel.org,
	conor+dt@kernel.org,  tudor.ambarus@linaro.org,
	krzk+dt@kernel.org, miquel.raynal@bootlin.com,
	 mwalle@kernel.org, linux-kernel@vger.kernel.org,
	claudiu.beznea@tuxon.dev,  vigneshr@ti.com,
	linux-arm-kernel@lists.infradead.org,
	 alexandre.belloni@bootlin.com, nicolas.ferre@microchip.com,
	 devicetree@vger.kernel.org, richard@nod.at
Subject: Re: [PATCH v3 0/3] Read MAC Address from SST vendor specific SFDP region
Date: Wed, 21 May 2025 07:56:11 -0500	[thread overview]
Message-ID: <174783212327.3233239.2531825211332843471.robh@kernel.org> (raw)
In-Reply-To: <20250521070336.402202-1-manikandan.m@microchip.com>

On Wed, 21 May 2025 12:33:33 +0530, Manikandan Muralidharan wrote:
> This patch series adds support to parse the SFDP SST vendor map, read and
> store the EUI-48 and EUI-64 Address (if its programmed) using the
> resource-managed devm_kcalloc which will be freed on driver detach.
> Register EUI addresses into NVMEM framework for the net drivers to access
> them using nvmem properties.
> This change ensures consistent and reliable MAC address retrieval
> from QSPI benefiting boards like the sama5d27_wlsom1, sama5d29 curiosity
> and sam9x75 curiosity.
> 
> --------
> changes in v3:
> - 2/3 - add support to update the QSPI partition into 'fixed-partition'
> 	binding in sama5d27_wlsom1
> - 3/3 - add nvmem-layout in qspi node for EUI48 MAC Address and nvmem cell
> 	properties for macb node in sama5d27_wlsom1
> 
> changes in v2:
> - 1/3 - parse the SST vendor table, read and store the addresses
> 	into a resource - managed space. Register the addresses
> 	into NVMEM framework
> - 2/3 - add support to update the QSPI partition into 'fixed-partition'
> 	binding
> --------
> 
> Manikandan Muralidharan (3):
>   mtd: spi-nor: sfdp: parse SFDP SST vendor map and register EUI
>     addresses into NVMEM framework
>   ARM: dts: microchip: sama5d27_wlsom1: update the QSPI partitions using
>     "fixed-partition" binding
>   ARM: dts: microchip: sama5d27_wlsom1: Add nvmem-layout in QSPI for
>     EUI48 MAC Address
> 
>  .../dts/microchip/at91-sama5d27_wlsom1.dtsi   |  65 ++++---
>  drivers/mtd/spi-nor/sfdp.c                    | 161 ++++++++++++++++++
>  include/linux/mtd/spi-nor.h                   |   7 +
>  3 files changed, 209 insertions(+), 24 deletions(-)
> 
> --
> 2.25.1
> 
> 
> 

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20250516 (best guess, 2/3 blobs matched)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/microchip/' for 20250521070336.402202-1-manikandan.m@microchip.com:

arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1_ek.dtb: flash@0 (jedec,spi-nor): Unevaluated properties are not allowed ('nvmem-layout', 'spi-cs-setup-ns' were unexpected)
	from schema $id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml#

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/