public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Alex Bee <knaerzche@gmail.com>
To: Tudor.Ambarus@microchip.com, macromorgan@hotmail.com,
	linux-mtd@lists.infradead.org
Cc: vigneshr@ti.com, richard@nod.at, miquel.raynal@bootlin.com
Subject: Re: [PATCH] mtd: spi-nor: XTX: Add support for XTX XT25F128B
Date: Fri, 2 Jul 2021 16:33:20 +0200	[thread overview]
Message-ID: <174a925e-4ab3-a043-c049-6407b1f6e5c7@gmail.com> (raw)
In-Reply-To: <bc09e0c7-bbf5-944d-ad8d-13b24e410e51@microchip.com>

Am 02.07.21 um 15:21 schrieb Tudor.Ambarus@microchip.com:
> On 7/2/21 3:49 PM, Alex Bee wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Hi Chris, guys
> 
> Hi,
> 
>>
>>
>> Am 02.04.21 um 22:15 schrieb Chris Morgan:
>>> Add support for a new vendor (XTX) along with a new chip from the
>>> vendor (XT25F128B). This chip is used in the Odroid Go Advance,
>>> and has been tested extensively using the spi-gpio driver, as it
>>> is connected to a serial flash controller that is not currently
>>> supported (but the pins can be repurposed to GPIO). Read, write, and
>>> erase all work as expected.
>> Once you've figured out how vendor id stuff is read out correctly, would
>> you mind also adding the the XT25F32B variant?
> 
> I've started working on this, here's the work in progress:
> https://github.com/ambarus/linux-0day/commits/spi-nor/next-id-collisions
> 
>>  From what I've checked it has all things in common with XT25F128B -
>> just has a 64 instead of 256 sectors.
>>
>> Datasheet can be found at:
>> https://datasheet.lcsc.com/szlcsc/2005251035_XTX-XT25F32BSOIGU-S_C558851.pdf
>>
>>>
>>> Datasheet can be found here:
>>> https://datasheet.lcsc.com/szlcsc/2005251034_XTX-XT25F128BSSIGT_C558844.pdf
>>>
> 
> we'll add just flashes that we can test. Do you have the flash at hand?

I do, yes. I'm currently adding devicetree support for the upcoming Rock 
Pi 4 plus revisions, which will have these flashes onboard.

After adding support for this variant ontop these patches (the wrong(?) 
flashid is 0x0b4016, btw.) everything is working as expected.

Since it has been requested - the sfpd table and other sysfs entries 
look like that:

~ # hexdump 
/sys/devices/platform/ff1d0000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp

0000000 4653 5044 0100 ff01 0000 0901 0030 ff00
0000010 000b 0301 0060 ff00 ffff ffff ffff ffff
0000020 ffff ffff ffff ffff ffff ffff ffff ffff
0000030 20e5 fff1 ffff 01ff eb44 6b08 3b08 bb42
0000040 ffee ffff ffff ff00 ffff ff00 200c 520f
0000050 d810 ff00 ffff ffff ffff ffff ffff ffff
0000060 3600 2700 7994 64ff e3fc ffff
000006c

~ # cat 
/sys/devices/platform/ff1d0000.spi/spi_master/spi0/spi0.0/spi-nor/jedec_id
0b4016

~ # cat 
/sys/devices/platform/ff1d0000.spi/spi_master/spi0/spi0.0/spi-nor/manufacturer 

xtx

~ # cat 
/sys/devices/platform/ff1d0000.spi/spi_master/spi0/spi0.0/spi-nor/partname
XT25F32B

Alex.
> 
> Cheers,
> ta
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2021-07-02 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02 20:15 [PATCH] mtd: spi-nor: XTX: Add support for XTX XT25F128B Chris Morgan
2021-04-05  8:52 ` Tudor.Ambarus
2021-04-05 19:16   ` Chris Morgan
2021-06-28  5:56     ` Tudor.Ambarus
2021-07-02 12:49 ` Alex Bee
2021-07-02 13:21   ` Tudor.Ambarus
2021-07-02 14:33     ` Alex Bee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174a925e-4ab3-a043-c049-6407b1f6e5c7@gmail.com \
    --to=knaerzche@gmail.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=macromorgan@hotmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox