Re: [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO SG2042

From: "Rob Herring (Arm)" <robh@kernel.org>
To: Zixian Zeng <sycamoremoon376@gmail.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	sophgo@lists.linux.dev,  Palmer Dabbelt <palmer@dabbelt.com>,
	Mark Brown <broonie@kernel.org>,
	 Chen Wang <unicorn_wang@outlook.com>,
	linux-mtd@lists.infradead.org,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-riscv@lists.infradead.org,
	 Conor Dooley <conor+dt@kernel.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	 linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	 Michael Walle <mwalle@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	Inochi Amaoto <inochiama@gmail.com>,
	 Alexandre Ghiti <alex@ghiti.fr>,
	Longbin Li <looong.bin@gmail.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO SG2042
Date: Sun, 29 Jun 2025 04:29:23 -0500	[thread overview]
Message-ID: <175118936320.3838715.11903647701453583408.robh@kernel.org> (raw)
In-Reply-To: <20250629-sfg-spifmc-v3-1-28db1f27e999@gmail.com>

On Sun, 29 Jun 2025 16:23:10 +0800, Zixian Zeng wrote:
> SG2042 is not fully compatiable with SG2044,
> So it is necessary to become independent const
> 
> Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml: properties:compatible:oneOf: [{'const': 'sophgo,sg2044-spifmc-nor'}, {'const': 'sophgo,sg2042-spifmc-nor'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}}
	hint: Use 'enum' rather than 'oneOf' + 'const' entries
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250629-sfg-spifmc-v3-1-28db1f27e999@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/