From: David Woodhouse <dwmw2@infradead.org>
To: Patrick Allaire <pallaire@gameloft.com>
Cc: Vipin Malik <Vipin.Malik@daniel.com>, linux-mtd@lists.infradead.org
Subject: Re: Applying MTD to 2.2.x kernel, with more info
Date: Tue, 14 Aug 2001 00:54:02 +0100 [thread overview]
Message-ID: <17616.997746842@redhat.com> (raw)
In-Reply-To: <9A1957CB9FC45A4FA6F35961093ABB8403E3E24D@srvmail-mtl.ubisoft.qc.ca>
It _should_ all work in 2.2, even as modules. But I don't test it often. I
really ought to verify it and fix the bits which break, then feed it to Alan
for 2.2.next.
pallaire@gameloft.com said:
> chipreg.c: In function `do_map_probe':
> chipreg.c:67: parse error before `do'
67: if (!drv && !request_module(name)) {
2.2 defines request_module as do{}while(0) ifndef CONFIG_KMOD. Which is
broken.
Index: include/linux/kmod.h
===================================================================
RCS file: /inst/cvs/linux/include/linux/kmod.h,v
retrieving revision 1.3
diff -u -r1.3 kmod.h
--- include/linux/kmod.h 2000/12/04 15:09:02 1.3
+++ include/linux/kmod.h 2001/08/13 23:53:05
@@ -13,7 +13,10 @@
#else
#include <linux/errno.h>
-#define request_module(x) do {} while(0)
+static inline int request_module(const char *name)
+{
+ return -EINVAL;
+}
static inline int exec_usermodehelper(char *program_path, char *argv[], char *envp[])
{
return -EACCES;
--
dwmw2
next prev parent reply other threads:[~2001-08-13 23:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-13 19:03 Applying MTD to 2.2.x kernel, with more info Patrick Allaire
2001-08-13 23:54 ` David Woodhouse [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-08-14 13:02 Patrick Allaire
2001-08-14 13:11 ` David Woodhouse
2001-08-14 14:18 ` David Woodhouse
2001-08-14 13:16 Patrick Allaire
2001-08-14 13:25 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17616.997746842@redhat.com \
--to=dwmw2@infradead.org \
--cc=Vipin.Malik@daniel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=pallaire@gameloft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox