From: Richard Weinberger <richard@nod.at>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: xiaolei li <xiaolei.li@mediatek.com>,
leqiao.peng@valeo.com, linux-mtd@lists.infradead.org
Subject: Re: UBIFS assert when create new sub-dir under a transmute enabled dir with Smack enabled
Date: Tue, 03 Jul 2018 17:25:29 +0200 [thread overview]
Message-ID: <1779495.8Qfuh5Rb3p@blindfold> (raw)
In-Reply-To: <a8dc6814-2fd4-b3de-21fb-f57af7792d7d@schaufler-ca.com>
Am Dienstag, 3. Juli 2018, 17:22:30 CEST schrieb Casey Schaufler:
> >> The root cause is that the inode isn't locked during inode instantiation
> >> (from Mr.Schaufler), but we check whether inode is locked in
> >> xattr_set.
>
> There is no need to do this check as all that
> gets done with the decision is to print the warning.
> The problem is the assumption that the inode is locked,
> which is doesn't have to be during instantiation.
I agree. Historically ubifs has a lot of (very good) asserts.
Some of them turn out to be too paranoid, like this one.
Thanks,
//richard
prev parent reply other threads:[~2018-07-03 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 9:04 UBIFS assert when create new sub-dir under a transmute enabled dir with Smack enabled xiaolei li
2018-07-01 8:23 ` Richard Weinberger
2018-07-03 6:05 ` xiaolei li
2018-07-03 7:22 ` Richard Weinberger
2018-07-03 15:22 ` Casey Schaufler
2018-07-03 15:25 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1779495.8Qfuh5Rb3p@blindfold \
--to=richard@nod.at \
--cc=casey@schaufler-ca.com \
--cc=leqiao.peng@valeo.com \
--cc=linux-mtd@lists.infradead.org \
--cc=xiaolei.li@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).