Re: root jffs2

[David Woodhouse <dwmw2@infradead.org>]

vipin.malik@daniel.com said:
>  David, that's an easy one. I'll just do a:
> $diff -u <new_version_that's_broken>   <old_version_that_worked>
> ;)


Where "broken" just isn't particularly convenient for you, and "worked" is 
the version that would wipe a cramfs root filesystem if jffs2 happened to 
be linked into the kernel first.

Quick way to get your CVS access revoked, that one :)

> More seriously, Nicolas just wrote that blank flash is not considered
> dirty and one can still mount a JFFS2 fs on it and hand populate it.

> Do you concur? 

No, we treat any block which is completely empty and doesn't contain a 
cleanmarker as dirty, because we can't be sure it was properly erased. 

How about changing the if(!c->used_size) at line 133 of scan.c to 
if(c->dirty_size) ?

Thinks... are we getting the accounting right in that case anyway? Why 
doesn't the final else case (/* Nothing valid... ) a few lines above change 
free_size?

--
dwmw2