Re: MTD CVS update: 'mtd/kernel mtdblock.c'

Re: MTD CVS update: 'mtd/kernel mtdblock.c'

[David Woodhouse]

sjhill@cotw.com said:
>  Made changes so that 'mtdblock' would build with 2.2.x kernels again
> and not only on ARM platforms. People PLEASE remember that this code
> is used in two different kernel trees AND on different CPU
> architectures. 

*(int *)0=0; doesn't cause an oops on all platforms. That was why BUG() was 
introduced. Probably better just to omit my paranoia checks altogether, 
once we're happy that mtdblock actually works. For now, surround them in 
#ifdef PARANOIA. I thought I'd done that already.

DECLARE_MUTEX_LOCKED wants adding to compatmac.h if it's not already there.

What was the reasoning for removing the 'static' from the declaration of 
thr_wq?

Anyway, it didn't build _only_ on ARM - it built on SH too :)

--
dwmw2




To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

Re: MTD CVS update: 'mtd/kernel mtdblock.c'

[Steven J. Hill]

David Woodhouse wrote:
> 
> *(int *)0=0; doesn't cause an oops on all platforms. That was why BUG() was
> introduced. Probably better just to omit my paranoia checks altogether,
> once we're happy that mtdblock actually works. For now, surround them in
> #ifdef PARANOIA. I thought I'd done that already.
> 
Alright, will do.

> DECLARE_MUTEX_LOCKED wants adding to compatmac.h if it's not already there.
> 
Will do.

> What was the reasoning for removing the 'static' from the declaration of
> thr_wq?
> 
Uhhh...that would be my stupidity. I forgot to put 'static' back on
the declaration.

-Steve

-- 
 Steven J. Hill - Embedded SW Engineer
 Public Key: 'finger sjhill@mail.cotw.com'
 FPR1: E124 6E1C AF8E 7802 A815
 FPR2: 7D72 829C 3386 4C4A E17D


To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

Proper way of setting MTD_DEBUG

[Bradley D. LaRonde]

What is the proper way of setting MTD_DEBUG?

Regards,
Brad



To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

Re: Proper way of setting MTD_DEBUG

[Steven J. Hill]

"Bradley D. LaRonde" wrote:
> 
> What is the proper way of setting MTD_DEBUG?
> 
I re-wrote the debugging such that it is now a configuration
option in the MTD sub-system menu where you choose the level
of verbosity. There a four levels which are defined in the
'include/linux/mtd/mtd.h' that you can use to define the
severity/verbosity of a debug statement.

-Steve

-- 
 Steven J. Hill - Embedded SW Engineer
 Public Key: 'finger sjhill@mail.cotw.com'
 FPR1: E124 6E1C AF8E 7802 A815
 FPR2: 7D72 829C 3386 4C4A E17D


To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

Re: Proper way of setting MTD_DEBUG

[Bradley D. LaRonde]

Ahh... I'm looking at an older version (the one in 2.4.0-test7).

Regards,
Brad

----- Original Message ----- 
From: "Steven J. Hill" <sjhill@cotw.com>
To: "Bradley D. LaRonde" <brad@ltc.com>
Cc: <mtd@infradead.org>
Sent: Tuesday, October 24, 2000 2:59 PM
Subject: Re: Proper way of setting MTD_DEBUG


> "Bradley D. LaRonde" wrote:
> > 
> > What is the proper way of setting MTD_DEBUG?
> > 
> I re-wrote the debugging such that it is now a configuration
> option in the MTD sub-system menu where you choose the level
> of verbosity. There a four levels which are defined in the
> 'include/linux/mtd/mtd.h' that you can use to define the
> severity/verbosity of a debug statement.
> 
> -Steve
> 
> -- 
>  Steven J. Hill - Embedded SW Engineer
>  Public Key: 'finger sjhill@mail.cotw.com'
>  FPR1: E124 6E1C AF8E 7802 A815
>  FPR2: 7D72 829C 3386 4C4A E17D



To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

MTD CVS update: 'mtd/kernel mtdblock.c'

[David Woodhouse]

Update of /home/cvs/mtd/kernel
In directory infradead.org:/tmp/cvs-serv27548

Modified Files:
	mtdblock.c 
Log Message:
Oops (literally). We don't want to do mtdblock_end_request() immediately
followed by end_request(). Thought I'd fixed that already.



To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

MTD CVS update: 'mtd/kernel mtdblock.c'

[David Woodhouse]

Update of /home/cvs/mtd/kernel
In directory infradead.org:/tmp/cvs-serv25296

Modified Files:
	mtdblock.c 
Log Message:
OK, so I broke it. Now it sets the sizes again, and as an added bonus it
also supports ioctls - so mkfs can work on it.



To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org