OneNAND git

OneNAND git

[Kyungmin Park]

Hi Artem Bityutskiy,

Okay no problem. I will clone your tree. 

But, first, To David Woodhouse please merge the Artem's onenand git tree for mtd git tree. then I will clone it.

Thank you,
Kyungmin Park


------- Original Message -------
Sender : Artem Bityutskiy<dedekind@infradead.org> 
Date   : Jan 10, 2007 22:18
Title  : Re: OneNAND git

Hi Kyungmin,

On Wed, 2007-01-10 at 00:43 +0000, Kyungmin Park wrote:
> I saw your tree. and please append the last patch, read-while-load in DDP handling.
> also we have to add "[MTD] OneNAND: fix onenand_wait bug".
Yeah, they are there.

> Then what's your opinion of JFFS2 patch?
> 
>     [JFFS2] Skip ECC position in NAND family flash
> 
>     In OneNAND it updates the spare ecc area automatically when write the
>     cleanmark in spare area

I think the problem should be fixed by means of MTD_OOB_AUTO option
instead.

> The remaing patches are following.
> 
> 1. [MTD] OneNAND: add subpage write support

It is cool to support this of course. I just forgot about it.

BTW, here is the idea how to test this. Just report mtd->writesize = 512
instead of 2048 temporarily. Then run some JFFS2 tests. O course, this
is just a hack for testing and you should report 2048 in mtd->writesize.

> 2. [JFFS2] fix wrong ref-flash_offset usage.

I think it is not OneNAND-related. I've put it to my
dedekind-mtd-2.6.git tree - will bug dwmw2 to pull from it. OK?


> I think thres's no problem of the removal of cond_resched in OneNAND driver.
> If you don't agree this one, I can revert it.

Revert a revert? :-)

Yes, I do not agree. Having large loops with no cond_resched() is not
nice. For example, MTD may be asked to read 64MiB of data at one go. And
we do this without releasing CPU and cause huge delays. This is bad.

Now I have all the patches in place in my tree. I offer you to consider
to clone my tee and maintain it instead. I do not actually wish to be a
OneNAND maintainer, just collected all the patches and made a bit neater
git tree. Some of them didn't apply cleanly, so I did some hand work.

Also, I change the author of my patch to me instead of you. :-)

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

Re: OneNAND git

[Artem Bityutskiy]

Hi Kyungmin,

On Wed, 2007-01-10 at 00:43 +0000, Kyungmin Park wrote:
> I saw your tree. and please append the last patch, read-while-load in DDP handling.
> also we have to add "[MTD] OneNAND: fix onenand_wait bug".
Yeah, they are there.

> Then what's your opinion of JFFS2 patch?
> 
>     [JFFS2] Skip ECC position in NAND family flash
> 
>     In OneNAND it updates the spare ecc area automatically when write the
>     cleanmark in spare area

I think the problem should be fixed by means of MTD_OOB_AUTO option
instead.

> The remaing patches are following.
> 
> 1. [MTD] OneNAND: add subpage write support

It is cool to support this of course. I just forgot about it.

BTW, here is the idea how to test this. Just report mtd->writesize = 512
instead of 2048 temporarily. Then run some JFFS2 tests. O course, this
is just a hack for testing and you should report 2048 in mtd->writesize.

> 2. [JFFS2] fix wrong ref-flash_offset usage.

I think it is not OneNAND-related. I've put it to my
dedekind-mtd-2.6.git tree - will bug dwmw2 to pull from it. OK?


> I think thres's no problem of the removal of cond_resched in OneNAND driver.
> If you don't agree this one, I can revert it.

Revert a revert? :-)

Yes, I do not agree. Having large loops with no cond_resched() is not
nice. For example, MTD may be asked to read 64MiB of data at one go. And
we do this without releasing CPU and cause huge delays. This is bad.

Now I have all the patches in place in my tree. I offer you to consider
to clone my tee and maintain it instead. I do not actually wish to be a
OneNAND maintainer, just collected all the patches and made a bit neater
git tree. Some of them didn't apply cleanly, so I did some hand work.

Also, I change the author of my patch to me instead of you. :-)

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

OneNAND git

[Kyungmin Park]

Hi,

I saw your tree. and please append the last patch, read-while-load in DDP handling.
also we have to add "[MTD] OneNAND: fix onenand_wait bug".

Then what's your opinion of JFFS2 patch?

    [JFFS2] Skip ECC position in NAND family flash

    In OneNAND it updates the spare ecc area automatically when write the
    cleanmark in spare area

I hope to commit this one, too

The remaing patches are following.

1. [MTD] OneNAND: add subpage write support
2. [JFFS2] fix wrong ref-flash_offset usage.

I wonder why don't you manage separate tree of OneNAND?
I think thres's no problem of the removal of cond_resched in OneNAND driver.
If you don't agree this one, I can revert it.

Thank you,
Kyungmin Park






------- Original Message -------
Sender : Artem Bityutskiy<dedekind@infradead.org> 
Date   : Jan 09, 2007 21:24
Title  : OneNAND git

Kyungmin,

please, look at my OneNAND tree here:
http://git.infradead.org/?p=users/dedekind/dedekind-onenand-mtd-2.6.git;a=summary

I do not have several of your patches there, but I excluded the ones I
think should not sit in this tree.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

OneNAND git

[Artem Bityutskiy]

Kyungmin,

please, look at my OneNAND tree here:
http://git.infradead.org/?p=users/dedekind/dedekind-onenand-mtd-2.6.git;a=summary

I do not have several of your patches there, but I excluded the ones I
think should not sit in this tree.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)