* [PATCH] mtd: nand: gpio: Fix ALE gpio configuration
@ 2017-12-06 17:27 Christophe Leroy
2017-12-06 22:28 ` Richard Weinberger
2017-12-10 0:26 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Christophe Leroy @ 2017-12-06 17:27 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, linus.walleij
Cc: linux-kernel, linux-mtd
Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio:
Convert to use GPIO descriptors") which breaks gpio-nand driver
Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors")
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
drivers/mtd/nand/gpio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c
index 484f7fbc3f7d..a8bde6665c24 100644
--- a/drivers/mtd/nand/gpio.c
+++ b/drivers/mtd/nand/gpio.c
@@ -253,9 +253,9 @@ static int gpio_nand_probe(struct platform_device *pdev)
goto out_ce;
}
- gpiomtd->nwp = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
- if (IS_ERR(gpiomtd->nwp)) {
- ret = PTR_ERR(gpiomtd->nwp);
+ gpiomtd->ale = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
+ if (IS_ERR(gpiomtd->ale)) {
+ ret = PTR_ERR(gpiomtd->ale);
goto out_ce;
}
--
2.13.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: nand: gpio: Fix ALE gpio configuration
2017-12-06 17:27 [PATCH] mtd: nand: gpio: Fix ALE gpio configuration Christophe Leroy
@ 2017-12-06 22:28 ` Richard Weinberger
2017-12-06 22:39 ` Boris Brezillon
2017-12-10 0:26 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2017-12-06 22:28 UTC (permalink / raw)
To: Christophe Leroy; +Cc: Boris Brezillon, linus.walleij, linux-kernel, linux-mtd
Am Mittwoch, 6. Dezember 2017, 18:27:14 CET schrieb Christophe Leroy:
> Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio:
> Convert to use GPIO descriptors") which breaks gpio-nand driver
>
> Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> drivers/mtd/nand/gpio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c
> index 484f7fbc3f7d..a8bde6665c24 100644
> --- a/drivers/mtd/nand/gpio.c
> +++ b/drivers/mtd/nand/gpio.c
> @@ -253,9 +253,9 @@ static int gpio_nand_probe(struct platform_device *pdev)
> goto out_ce;
> }
>
> - gpiomtd->nwp = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> - if (IS_ERR(gpiomtd->nwp)) {
> - ret = PTR_ERR(gpiomtd->nwp);
> + gpiomtd->ale = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> + if (IS_ERR(gpiomtd->ale)) {
> + ret = PTR_ERR(gpiomtd->ale);
> goto out_ce;
> }
Reviewed-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: nand: gpio: Fix ALE gpio configuration
2017-12-06 22:28 ` Richard Weinberger
@ 2017-12-06 22:39 ` Boris Brezillon
2017-12-06 22:45 ` Boris Brezillon
0 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2017-12-06 22:39 UTC (permalink / raw)
To: Richard Weinberger
Cc: Christophe Leroy, linus.walleij, linux-kernel, linux-mtd
On Wed, 06 Dec 2017 23:28:11 +0100
Richard Weinberger <richard@nod.at> wrote:
> Am Mittwoch, 6. Dezember 2017, 18:27:14 CET schrieb Christophe Leroy:
> > Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio:
> > Convert to use GPIO descriptors") which breaks gpio-nand driver
> >
> > Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors")
> > Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: <stable@vger.kernel.org>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Richard, can you queue that one to the fixes branch?
> > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > ---
> > drivers/mtd/nand/gpio.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c
> > index 484f7fbc3f7d..a8bde6665c24 100644
> > --- a/drivers/mtd/nand/gpio.c
> > +++ b/drivers/mtd/nand/gpio.c
> > @@ -253,9 +253,9 @@ static int gpio_nand_probe(struct platform_device *pdev)
> > goto out_ce;
> > }
> >
> > - gpiomtd->nwp = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> > - if (IS_ERR(gpiomtd->nwp)) {
> > - ret = PTR_ERR(gpiomtd->nwp);
> > + gpiomtd->ale = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> > + if (IS_ERR(gpiomtd->ale)) {
> > + ret = PTR_ERR(gpiomtd->ale);
> > goto out_ce;
> > }
>
> Reviewed-by: Richard Weinberger <richard@nod.at>
>
> Thanks,
> //richard
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: nand: gpio: Fix ALE gpio configuration
2017-12-06 22:39 ` Boris Brezillon
@ 2017-12-06 22:45 ` Boris Brezillon
0 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2017-12-06 22:45 UTC (permalink / raw)
To: Richard Weinberger
Cc: Christophe Leroy, linus.walleij, linux-kernel, linux-mtd
On Wed, 6 Dec 2017 23:39:27 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Wed, 06 Dec 2017 23:28:11 +0100
> Richard Weinberger <richard@nod.at> wrote:
>
> > Am Mittwoch, 6. Dezember 2017, 18:27:14 CET schrieb Christophe Leroy:
> > > Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio:
> > > Convert to use GPIO descriptors") which breaks gpio-nand driver
> > >
> > > Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors")
> > > Cc: Linus Walleij <linus.walleij@linaro.org>
>
> Cc: <stable@vger.kernel.org>
Oops, forget the Cc-stable tag, f3d0d8d938b4d has been merged in
4.15-rc1.
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Richard, can you queue that one to the fixes branch?
>
> > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > > ---
> > > drivers/mtd/nand/gpio.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c
> > > index 484f7fbc3f7d..a8bde6665c24 100644
> > > --- a/drivers/mtd/nand/gpio.c
> > > +++ b/drivers/mtd/nand/gpio.c
> > > @@ -253,9 +253,9 @@ static int gpio_nand_probe(struct platform_device *pdev)
> > > goto out_ce;
> > > }
> > >
> > > - gpiomtd->nwp = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> > > - if (IS_ERR(gpiomtd->nwp)) {
> > > - ret = PTR_ERR(gpiomtd->nwp);
> > > + gpiomtd->ale = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> > > + if (IS_ERR(gpiomtd->ale)) {
> > > + ret = PTR_ERR(gpiomtd->ale);
> > > goto out_ce;
> > > }
> >
> > Reviewed-by: Richard Weinberger <richard@nod.at>
> >
> > Thanks,
> > //richard
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: nand: gpio: Fix ALE gpio configuration
2017-12-06 17:27 [PATCH] mtd: nand: gpio: Fix ALE gpio configuration Christophe Leroy
2017-12-06 22:28 ` Richard Weinberger
@ 2017-12-10 0:26 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2017-12-10 0:26 UTC (permalink / raw)
To: Christophe Leroy
Cc: Boris Brezillon, Richard Weinberger, linux-kernel@vger.kernel.org,
linux-mtd
On Wed, Dec 6, 2017 at 6:27 PM, Christophe Leroy
<christophe.leroy@c-s.fr> wrote:
> Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio:
> Convert to use GPIO descriptors") which breaks gpio-nand driver
>
> Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Sorry about that :(
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-10 0:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-06 17:27 [PATCH] mtd: nand: gpio: Fix ALE gpio configuration Christophe Leroy
2017-12-06 22:28 ` Richard Weinberger
2017-12-06 22:39 ` Boris Brezillon
2017-12-06 22:45 ` Boris Brezillon
2017-12-10 0:26 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox