* Re: MTD CVS update: 'mtd/kernel doc2001.c'
[not found] <E13oMJV-0003oY-00@infradead.org>
@ 2000-10-25 9:01 ` David Woodhouse
2000-10-25 10:01 ` Ollie Lho
0 siblings, 1 reply; 3+ messages in thread
From: David Woodhouse @ 2000-10-25 9:01 UTC (permalink / raw)
To: ollie; +Cc: mtd
ollie@infradead.org said:
> Log Message:
> use memcpy_(from|to)_io to increase perfromance a little bit
Here be dragons.
Beware that this doesn't start trying to do 32-bit accesses, where the top
three bytes are random, and that it doesn't break the ECC.
Probably worth setting USE_MEMCPY in include/linux/mtd/doc2000.h in with
all the other arch-dependent stuff to set up ReadDOC etc.
--
dwmw2
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: MTD CVS update: 'mtd/kernel doc2001.c'
2000-10-25 9:01 ` MTD CVS update: 'mtd/kernel doc2001.c' David Woodhouse
@ 2000-10-25 10:01 ` Ollie Lho
2000-10-26 6:46 ` Udi Finkelstein
0 siblings, 1 reply; 3+ messages in thread
From: Ollie Lho @ 2000-10-25 10:01 UTC (permalink / raw)
To: David Woodhouse; +Cc: mtd
David Woodhouse wrote:
>
> ollie@infradead.org said:
> > Log Message:
> > use memcpy_(from|to)_io to increase perfromance a little bit
>
> Here be dragons.
>
> Beware that this doesn't start trying to do 32-bit accesses, where the top
> three bytes are random, and that it doesn't break the ECC.
>
> Probably worth setting USE_MEMCPY in include/linux/mtd/doc2000.h in with
> all the other arch-dependent stuff to set up ReadDOC etc.
>
Oops, sorry. I just copy it from the dis-asm of M-Systems' driver.
USE_MEMCPY should be protected by #ifdef 386 stuff.
Ollie
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: MTD CVS update: 'mtd/kernel doc2001.c'
2000-10-25 10:01 ` Ollie Lho
@ 2000-10-26 6:46 ` Udi Finkelstein
0 siblings, 0 replies; 3+ messages in thread
From: Udi Finkelstein @ 2000-10-26 6:46 UTC (permalink / raw)
To: mtd
On Wed, 25 Oct 2000 18:01:13 +0800, Ollie Lho <ollie@sis.com.tw> wrote:
>David Woodhouse wrote:
>>
>> ollie@infradead.org said:
>> > Log Message:
>> > use memcpy_(from|to)_io to increase perfromance a little bit
>>
>> Here be dragons.
>>
>> Beware that this doesn't start trying to do 32-bit accesses, where the top
>> three bytes are random, and that it doesn't break the ECC.
>>
>> Probably worth setting USE_MEMCPY in include/linux/mtd/doc2000.h in with
>> all the other arch-dependent stuff to set up ReadDOC etc.
>>
>
>Oops, sorry. I just copy it from the dis-asm of M-Systems' driver.
>USE_MEMCPY should be protected by #ifdef 386 stuff.
Do you put code disassembled from a proprietary M-systems' driver into a GPL
driver?
Do we really want that?
>Ollie
udi
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2000-10-26 6:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E13oMJV-0003oY-00@infradead.org>
2000-10-25 9:01 ` MTD CVS update: 'mtd/kernel doc2001.c' David Woodhouse
2000-10-25 10:01 ` Ollie Lho
2000-10-26 6:46 ` Udi Finkelstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox