Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <alexander.sverdlin@nokia.com>
Cc: vigneshr@ti.com, sergei.shtylyov@cogentembedded.com,
	richard@nod.at, john.garry@huawei.com, linuxarm@huawei.com,
	yangyicong@hisilicon.com, linux-mtd@lists.infradead.org,
	miquel.raynal@bootlin.com
Subject: Re: [PATCH] mtd: spi-nor: sfdp: Fix wrong addr length and dummy when perform SMPT detection command
Date: Tue, 21 Apr 2020 11:14:32 +0000	[thread overview]
Message-ID: <1978273.VT0C5YHoa6@192.168.0.120> (raw)
In-Reply-To: <6c3bdfd9-1fd8-6a8e-0e30-03eb82f1f244@nokia.com>

On Tuesday, April 21, 2020 1:39:14 PM EEST Alexander Sverdlin wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Hi!

Hi,

> 
> On 21/04/2020 11:58, Tudor.Ambarus@microchip.com wrote:
> >> Well this will work and as the maintainers ignore the proper and even
> >> recommended by them solution,
> > 
> > There will be no patch left behind or ignored. Your patch is still pending
> > in the review state because I need some time to study the problem and I
> > couldn't allocate time for this yet. But I will address it in a week or
> > so.
> With all the rework of spi-nor it barely makes sense and if I rework the
> patches there is no way they can be backported to stable. I wonder why at
> all subsystem rework is prioritized over bugfixes in MTD.
 
You don't have to send a new version, I can review it in the form it is now. 
Also, I can port the patch to the latest spi-nor/next if I'll find it good, 
and you'll not feel like respining. Once we agree on the final form of the 
patch, we can backport it to stable if you care.

I prioritized the subsystem rework because it will be easier/clearer for 
others to write new code, and because it eased the maintainance. Maybe it was 
better to fix all the known bugs before reworking the subsystem, but that is a 
lesson to learn.

Cheers,
ta


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-04-21 11:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21  3:30 [PATCH] mtd: spi-nor: sfdp: Fix wrong addr length and dummy when perform SMPT detection command Yicong Yang
2020-04-21  7:54 ` Alexander Sverdlin
2020-04-21  9:58   ` Tudor.Ambarus
2020-04-21 10:39     ` Alexander Sverdlin
2020-04-21 11:14       ` Tudor.Ambarus [this message]
2020-04-21 11:44 ` Pratyush Yadav
2020-04-21 12:25   ` Yicong Yang
2020-04-22 13:51     ` Pratyush Yadav
2020-04-23 11:09       ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1978273.VT0C5YHoa6@192.168.0.120 \
    --to=tudor.ambarus@microchip.com \
    --cc=alexander.sverdlin@nokia.com \
    --cc=john.garry@huawei.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxarm@huawei.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=vigneshr@ti.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox