From: Richard Weinberger <richard@nod.at>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-mtd@lists.infradead.org,
Artem Bityutskiy <dedekind1@gmail.com>,
kernel@pengutronix.de, Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-ima-devel@lists.sourceforge.net
Subject: Re: [PATCH] fs: ubifs: Add i_version support
Date: Tue, 12 Sep 2017 16:50:13 +0200 [thread overview]
Message-ID: <1996861.9Gom84rckB@blindfold> (raw)
In-Reply-To: <20170912142318.4x3qg6chohykobb6@pengutronix.de>
Sascha,
Am Dienstag, 12. September 2017, 16:23:18 CEST schrieb Sascha Hauer:
> > So, for the IMA use-case we don't even have to persist i_version.
> > That would be cool.
>
> Yes, that's what earlier versions of this patch did, nacked by Christoph
>
> Hellwig with the words:
> > Maybe IMA doesn't care, but if you set MS_I_VERSION the fs does give
> > a guarantee. Sp NAK on this patch as-is.
>
> (see https://lkml.org/lkml/2017/4/12/61)
>
> Reading this sentence again it may be a possibility to just increase the
> i_version field without setting the MS_I_VERSION flag.
Yes.
> > I need to read what other filesystems do, it is still not completely clear
> > to me what the expected i_version semantics are. Satisfying IMA seems to
> > be easy but we need to be very sure to not break other futuer i_version
> > users...
> Sure. I am also not sure whether I implemented it correctly since it's
> implementation defined by some filesystem drivers which I am afraid are
> not even consistent.
As usual, let's try to keep at least UBIFS kind of sane. ;-)
Thanks,
//richard
prev parent reply other threads:[~2017-09-12 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 10:39 [PATCH] fs: ubifs: Add i_version support Sascha Hauer
2017-09-12 12:38 ` Richard Weinberger
2017-09-12 13:46 ` Sascha Hauer
2017-09-12 13:57 ` Richard Weinberger
2017-09-12 14:23 ` Sascha Hauer
2017-09-12 14:50 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1996861.9Gom84rckB@blindfold \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox