From: Kevin Cernekee <cernekee@gmail.com>
To: <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: [PATCH] mkfs.ubifs: Fix --squash-rino-perm / --nosquash-rino-perm
Date: Thu, 23 Sep 2010 15:58:48 -0700 [thread overview]
Message-ID: <1a602213cef25044c025cc1aaf873cf5@localhost> (raw)
This addresses a couple of issues:
1) Code was only allowing these options if --root was NOT specified (the
opposite of the documented usage)
2) -q / -Q short options did not work
3) Spacing fixes in the error/warning strings
Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
---
mkfs.ubifs/mkfs.ubifs.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/mkfs.ubifs/mkfs.ubifs.c b/mkfs.ubifs/mkfs.ubifs.c
index ec38f0e..d83f6bd 100644
--- a/mkfs.ubifs/mkfs.ubifs.c
+++ b/mkfs.ubifs/mkfs.ubifs.c
@@ -132,7 +132,7 @@ static struct inum_mapping **hash_table;
/* Inode creation sequence number */
static unsigned long long creat_sqnum;
-static const char *optstring = "d:r:m:o:D:h?vVe:c:g:f:P:k:x:X:j:R:l:j:U";
+static const char *optstring = "d:r:m:o:D:h?vVe:c:g:f:P:k:x:X:j:R:l:j:UQq";
static const struct option longopts[] = {
{"root", 1, NULL, 'r'},
@@ -698,8 +698,8 @@ static int get_options(int argc, char**argv)
return err_msg("Maximum count of LEBs was not specified "
"(use -h for help)");
- if (squash_rino_perm != -1 && root)
- return err_msg("--squash-rino-perm and nosquash-rino-perm options"
+ if (squash_rino_perm != -1 && !root)
+ return err_msg("--squash-rino-perm and nosquash-rino-perm options "
"can be used only with the --root option");
if (c->max_bud_bytes == -1) {
@@ -1673,7 +1673,7 @@ static int write_data(void)
if (squash_rino_perm == -1) {
printf("WARNING: setting root UBIFS inode UID=GID=0 (root) and permissions "
"to u+rwx,go+rx; use --squash-rino-perm or --nosquash-rino-perm "
- "to suppress this warning");
+ "to suppress this warning\n");
squash_rino_perm = 1;
}
if (squash_rino_perm) {
--
1.7.0.4
next reply other threads:[~2010-09-23 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 22:58 Kevin Cernekee [this message]
2010-09-24 8:51 ` [PATCH] mkfs.ubifs: Fix --squash-rino-perm / --nosquash-rino-perm Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a602213cef25044c025cc1aaf873cf5@localhost \
--to=cernekee@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).