From: Krzysztof Kozlowski <krzk@kernel.org>
To: Santhosh Kumar K <s-k6@ti.com>
Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, miquel.raynal@bootlin.com, richard@nod.at,
vigneshr@ti.com, pratyush@kernel.org, mwalle@kernel.org,
takahiro.kuwano@infineon.com, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, praneeth@ti.com, u-kumar1@ti.com,
a-dutta@ti.com, Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v5 01/17] spi: dt-bindings: add spi-max-post-config-frequency-hz property
Date: Mon, 20 Jul 2026 12:09:42 +0200 [thread overview]
Message-ID: <1a681388-5ffe-4df9-83bf-a7622ee489bf@kernel.org> (raw)
In-Reply-To: <d6b3c768-bff2-40b1-b767-f17219281fb7@ti.com>
On 20/07/2026 10:48, Santhosh Kumar K wrote:
>
>
> On 20/07/26 13:10, Krzysztof Kozlowski wrote:
>> On 20/07/2026 09:38, Santhosh Kumar K wrote:
>>>>> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
>>>>> index 880a9f624566..12211f8c9f7d 100644
>>>>> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
>>>>> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
>>>>> @@ -45,6 +45,11 @@ properties:
>>>>> description:
>>>>> Maximum SPI clocking speed of the device in Hz.
>>>>>
>>>>> + spi-max-post-config-frequency-hz:
>>>>> + description:
>>>>> + Maximum SPI clock frequency in Hz achievable after controller-side
>>>>> + configuration.
>>>>
>>>> How did you implement my feedback?
>>>
>>> Three points from your feedback:
>>>
>>> 1. -hz suffix: added
>>>
>>> 2. Array property: I still lean towards keeping this as a scalar for
>>> now, as we don't have a concrete use case for multiple values today, and
>>> supporting two frequencies should be sufficient for the foreseeable
>>> future. I had responded to this in the v4 discussion as well, you may
>>> have missed that response.
>>>
>>> 3. maxItems: Since the property remains a scalar, I have not added maxItems.
>>
>> So how did you make this property scalar?
>
> The -hz suffix constraints the property to a uint32 scalar through the
> DT schema framework's property-units.yaml.
Hm, where? I completely missed that, can you point me to the specific
line? I see clearly that it is not a scalar.
>
> Adding an explicit $ref or maxItems for a unit-suffixed property is
> rejected by dtbs_check with:
> - "Standard unit suffix properties don't need a type $ref"
This I did not propose - the type is fixed.
> - "Scalar properties should not have array keywords"
Cannot reproduce it.
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-07-20 10:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 18:50 [PATCH v5 00/17] spi: cadence-quadspi: add PHY tuning support Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 01/17] spi: dt-bindings: add spi-max-post-config-frequency-hz property Santhosh Kumar K
2026-07-19 6:53 ` Krzysztof Kozlowski
2026-07-20 7:38 ` Santhosh Kumar K
2026-07-20 7:40 ` Krzysztof Kozlowski
2026-07-20 8:48 ` Santhosh Kumar K
2026-07-20 10:09 ` Krzysztof Kozlowski [this message]
2026-07-20 10:34 ` Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 02/17] spi: dt-bindings: add spi-phy-pattern-partition property Santhosh Kumar K
2026-07-19 6:54 ` Krzysztof Kozlowski
2026-07-17 18:51 ` [PATCH v5 03/17] spi: parse spi-max-post-config-frequency-hz into post_config_max_speed_hz Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 04/17] spi: spi-mem: teach spi_mem_adjust_op_freq() about post-config ops Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 05/17] spi: spi-mem: add execute_tuning callback and spi_mem_execute_tuning() Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 06/17] spi: cadence-quadspi: move cqspi_readdata_capture earlier Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 07/17] spi: cadence-quadspi: add DQS support to read data capture Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 08/17] spi: cadence-quadspi: add PHY tuning support Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 09/17] spi: cadence-quadspi: skip DDR PHY tuning for 2-byte-address ops (i2383) Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 10/17] spi: cadence-quadspi: refactor direct read path for PHY support Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 11/17] spi: cadence-quadspi: enable PHY for direct reads Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 12/17] spi: cadence-quadspi: enable PHY for indirect writes Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 13/17] spi: cadence-quadspi: reprogram CS timing on every chip-select switch Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 14/17] mtd: spinand: extract variant ranking logic into spinand_op_find_best_variant() Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 15/17] mtd: spinand: negotiate optimal controller operating point before dirmap creation Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 16/17] mtd: spi-nor: extract read op template construction into helper Santhosh Kumar K
2026-07-17 18:51 ` [PATCH v5 17/17] mtd: spi-nor: run controller optimization before dirmap creation Santhosh Kumar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a681388-5ffe-4df9-83bf-a7622ee489bf@kernel.org \
--to=krzk@kernel.org \
--cc=a-dutta@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=praneeth@ti.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=s-k6@ti.com \
--cc=takahiro.kuwano@infineon.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox