From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Christopher Cordahi <christophercordahi@nanometrics.ca>
Subject: Re: [PATCH 4/5] mtd: rawnand: davinci: Add clock resource
Date: Wed, 30 Oct 2024 15:26:32 +0100 [thread overview]
Message-ID: <1aab934c-d28e-4ee8-a857-ffc2ef739488@kernel.org> (raw)
In-Reply-To: <58a1b909-7ed7-40a4-8845-b8327a1d740c@bootlin.com>
On 30/10/2024 13:20, Bastien Curutchet wrote:
> Hi Krzysztof,
>
> On 10/30/24 12:17 PM, Krzysztof Kozlowski wrote:
>> On 30/10/2024 11:47, Bastien Curutchet wrote:
>>> NAND controller has a reference clock but the driver doesn't use it.
>>>
>>> Add a struct clock in the struct davinci_nand_info so it can be used
>>> to compute timings.
>>>
>>> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
>>> ---
>>> drivers/mtd/nand/raw/davinci_nand.c | 9 +++++++++
>>
>> Where are the bindings?
>>
>
> The NAND controller bindings are in
> Documentation/devicetree/bindings/mtd/davinci-nand.txt but this clock is
> defined in the AEMIF bindings in
> Documentation/devicetree/bindings/memory-controllers/ti-aemif.txt
Mention this in commit msg so you get one reviewer question less...
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-10-30 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 10:47 [PATCH 0/5] Implement setup_inteface() in the DaVinci NAND controller Bastien Curutchet
2024-10-30 10:47 ` [PATCH 1/5] memory: ti-aemif: Create aemif_set_cs_timings() Bastien Curutchet
2024-10-30 10:47 ` [PATCH 2/5] memory: ti-aemif: export aemif_set_cs_timing() Bastien Curutchet
2024-10-31 5:42 ` kernel test robot
2024-10-30 10:47 ` [PATCH 3/5] mtd: rawnand: davinci: Order headers alphabetically Bastien Curutchet
2024-10-30 10:47 ` [PATCH 4/5] mtd: rawnand: davinci: Add clock resource Bastien Curutchet
2024-10-30 11:17 ` Krzysztof Kozlowski
2024-10-30 12:20 ` Bastien Curutchet
2024-10-30 14:26 ` Krzysztof Kozlowski [this message]
2024-10-30 10:47 ` [PATCH 5/5] mtd: rawnand: davinci: Implement setup_interface() operation Bastien Curutchet
2024-11-01 18:11 ` kernel test robot
2024-11-02 2:04 ` kernel test robot
2024-10-30 11:17 ` [PATCH 0/5] Implement setup_inteface() in the DaVinci NAND controller Krzysztof Kozlowski
2024-10-30 12:39 ` Bastien Curutchet
2024-10-30 14:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aab934c-d28e-4ee8-a857-ffc2ef739488@kernel.org \
--to=krzk@kernel.org \
--cc=bastien.curutchet@bootlin.com \
--cc=christophercordahi@nanometrics.ca \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=ssantosh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox