Re: [RFC PATCH 05/18] drbd: use init disk helper

From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
	"Chaitanya Kulkarni" <chaitanyak@nvidia.com>
Cc: "ogeert@linux-m68k.org" <ogeert@linux-m68k.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-m68k@lists.linux-m68k.org"
	<linux-m68k@lists.linux-m68k.org>,
	"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>,
	"nbd@other.debian.org" <nbd@other.debian.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"philipp.reisner@linbit.com" <philipp.reisner@linbit.com>,
	"lars.ellenberg@linbit.com" <lars.ellenberg@linbit.com>,
	"efremov@linux.com" <efremov@linux.com>,
	"josef@toxicpanda.com" <josef@toxicpanda.com>,
	"tim@cyberelk.net" <tim@cyberelk.net>,
	"haris.iqbal@ionos.com" <haris.iqbal@ionos.com>,
	"jinpu.wang@ionos.com" <jinpu.wang@ionos.com>,
	"richard@nod.at" <richard@nod.at>,
	"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>,
	"hare@suse.de" <hare@suse.de>,
	"damien.lemoal@opensource.wdc.com"
	<damien.lemoal@opensource.wdc.com>,
	"johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"ming.lei@redhat.com" <ming.lei@redhat.com>,
	"vincent.fu@samsung.com" <vincent.fu@samsung.com>,
	"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>
Subject: Re: [RFC PATCH 05/18] drbd: use init disk helper
Date: Wed, 5 Oct 2022 17:24:22 +0000	[thread overview]
Message-ID: <1e2cbfd0-6136-df9e-58fb-60f1375b2e79@nvidia.com> (raw)
In-Reply-To: <e23e94f8-13ad-4a10-62de-33e63a62831f@linbit.com>

>> diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
>> index f3e4db16fd07..58fae122de16 100644
>> --- a/drivers/block/drbd/drbd_main.c
>> +++ b/drivers/block/drbd/drbd_main.c
>> @@ -2706,13 +2706,9 @@ enum drbd_ret_code drbd_create_device(struct drbd_config_context *adm_ctx, unsig
>>   
>>   	set_disk_ro(disk, true);
>>   
>> -	disk->major = DRBD_MAJOR;
>> -	disk->first_minor = minor;
>> -	disk->minors = 1;
>> -	disk->fops = &drbd_ops;
>>   	disk->flags |= GENHD_FL_NO_PART;
>>   	sprintf(disk->disk_name, "drbd%d", minor);
>> -	disk->private_data = device;
>> +	init_disk(disk, DRBD_MAJOR, minor, 1, 0, device, &drbd_ops);
>>   
>>   	blk_queue_flag_set(QUEUE_FLAG_STABLE_WRITES, disk->queue);
>>   	blk_queue_write_cache(disk->queue, true, true);
> 
> This now does a set_capacity(..., 0), which it did not do before.
> I'm guessing this does not have any side effects as the capacity should
> already be initialized to 0? Do you know this for sure?
> 

I think I'll move  the call to set_capcity out of the caller,
Will resend the series shortly.

-ck

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/