From: Henrik Nordstrom <hno@marasystems.com>
To: "Xiaogeng (Shawn) Jin" <xjin@redswitch.com>,
linux-mtd@lists.infradead.org
Subject: [patch] Re: the latest MTD code from CVS has compilation errors
Date: Thu, 29 Aug 2002 10:55:16 +0200 [thread overview]
Message-ID: <200208291055.16498@henrik.marasystems.com> (raw)
In-Reply-To: <3D6D8BC6.8000909@redswitch.com>
[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]
I have the same problem with 2.4.18. See post a few days ago about
DOC2000.
A closer look at the problem inticates the problem is not the CVS
sources but the patchin.sh script used to apply them to the kernel
tree. It does not apply the new jffs2 sources to the kernel tree,
crashing the old jffs2 code by replacing mtd headers..
However, applying the new code to stock 2.4.18 does not work either
due to a missing include/linux/crc32.h (is in fs/jffs2/crc32.h)
Attached is a small patch to the patchin.sh script to have the new
jffs2 code applied to the kernel tree.
Regards
Henrik
On Thursday 29 August 2002 04.49, Xiaogeng (Shawn) Jin wrote:
> Hi,
>
> I tried to compile the latest MTD code got from CVS tree on linux
> 2.4.4 (from DENX). When fs/jffs2/background.c is compiled, it
> complains that background.c:108: arguments given to macro
> 'recalc_sigpending' background.c:155: arguments given to macro
> 'recalc_sigpending' errors. I looked into the code and included
> header file. In linux/mtd/compatmac.h the macro is re-defined to
> have no arguments at all if kernel version < 2.5.5. So in my case
> 108 and 155 should be changed to have no arguments.
>
> Anybody reported this "bug" before?
>
> - Shawn.
>
> PS: compatmac.h's modification date is 2002/08/07, version v1.39.
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
[-- Attachment #2: mtd-2.4.patch --]
[-- Type: text/x-diff, Size: 1082 bytes --]
Index: patches/patchin.sh
===================================================================
RCS file: /home/cvs/mtd/patches/patchin.sh,v
retrieving revision 1.6
diff -u -r1.6 patchin.sh
--- patches/patchin.sh 25 Apr 2001 12:10:23 -0000 1.6
+++ patches/patchin.sh 29 Aug 2002 08:52:37 -0000
@@ -30,6 +30,7 @@
mkdir -p drivers/mtd/nand
mkdir -p include/linux/mtd
mkdir -p fs/jffs
+mkdir -p fs/jffs2
ln -sf $TOPDIR/drivers/mtd/*.[ch] drivers/mtd
ln -sf $TOPDIR/drivers/mtd/*akefile $TOPDIR/drivers/mtd/Rules.make $TOPDIR/drivers/mtd/Config.in drivers/mtd
ln -sf $TOPDIR/drivers/mtd/chips/*.[ch] drivers/mtd/chips
@@ -43,7 +44,13 @@
ln -sf $TOPDIR/fs/jffs/*.[ch] fs/jffs
ln -sf $TOPDIR/fs/jffs/*akefile fs/jffs
ln -sf $TOPDIR/include/linux/jffs.h include/linux
+ln -sf $TOPDIR/fs/jffs2/*.[ch] fs/jffs2
+ln -sf $TOPDIR/fs/jffs2/*akefile fs/jffs2
+ln -sf $TOPDIR/include/linux/jffs2*.h include/linux
+ln -sf $TOPDIR/include/linux/z*.h include/linux
+ln -sf $TOPDIR/fs/jffs2/crc32.h include/linux
ln -sf $TOPDIR/include/linux/mtd/*.h include/linux/mtd
+
#
# kernel patches
prev parent reply other threads:[~2002-08-29 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-29 2:49 the latest MTD code from CVS has compilation errors Xiaogeng (Shawn) Jin
2002-08-29 8:55 ` Henrik Nordstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200208291055.16498@henrik.marasystems.com \
--to=hno@marasystems.com \
--cc=linux-mtd@lists.infradead.org \
--cc=xjin@redswitch.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox