public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Steve Wahl <swahl@brecis.com>
To: Jasmine Strong <jasmine@hex.linuxgrrls.org>
Cc: Allen Curtis <acurtis@onz.com>,
	David Woodhouse <dwmw2@infradead.org>,
	John Hall <John.Hall@optionexist.co.uk>,
	"Linux MTD list (E-mail)" <linux-mtd@lists.infradead.org>
Subject: Re: Stable cvs version for 2.4
Date: Wed, 4 Sep 2002 10:17:06 -0500	[thread overview]
Message-ID: <20020904101706.D23398@brecis.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0209041551460.22265-100000@hex.linuxgrrls.org>; from jasmine@hex.linuxgrrls.org on Wed, Sep 04, 2002 at 03:54:03PM +0100

On Wed, Sep 04, 2002 at 03:54:03PM +0100, Jasmine Strong wrote:
> 
> 
> On Wed, 4 Sep 2002, Allen Curtis wrote:
> 
> > How about we add 1 byte which contains up to 8 bit fields?
> 
> Adding a byte will destroy the alignment.  you'd have to add a whole word.
> 
> We could have a #define to set whether we use the lsb of the address (on
> aligned architectures) or an extra byte (on non-aligned architectures,
> which won't care about the structure not being an exact multiple of words
> anyway).

My $0.02 is: 

The #define is a good suggestion.  

But the assumption that using the lsb of the pointer will only break
on archetectures that don't care about alignment may be a bad one.

I haven't looked at the code (shame on me...), but I thought I heard
the word "tree" mentioned. :-) If this data structure is being used
for speed, I have to ask if the extra masking instructions are a good
trade off for the memory saved?

--> Steve

  reply	other threads:[~2002-09-04 15:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-03 10:09 Stable cvs version for 2.4 John Hall
2002-09-03 12:29 ` David Woodhouse
2002-09-04  0:18   ` David Woodhouse
2002-09-04  1:14     ` Jasmine Strong
2002-09-04  8:51       ` David Woodhouse
2002-09-04 14:21         ` Jasmine Strong
2002-09-04 14:37           ` David Woodhouse
2002-09-04 14:46             ` Allen Curtis
2002-09-04 14:54               ` Jasmine Strong
2002-09-04 15:17                 ` Steve Wahl [this message]
2002-09-04 15:26                   ` David Woodhouse
2002-09-04 15:20                 ` David Woodhouse
2002-09-04 15:33                   ` Jasmine Strong
2002-09-04 15:44                     ` David Woodhouse
2002-09-04 15:50                     ` Allen Curtis
2002-09-04 15:54                       ` David Woodhouse
2002-09-04 14:49             ` Jasmine Strong
2002-09-04 15:06               ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020904101706.D23398@brecis.com \
    --to=swahl@brecis.com \
    --cc=John.Hall@optionexist.co.uk \
    --cc=acurtis@onz.com \
    --cc=dwmw2@infradead.org \
    --cc=jasmine@hex.linuxgrrls.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox