Re: [PATCH] add access to AMD secure silicon area

[Clive Davies <cdavies@altera.com>]

>
> +	cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi,
> CFI_DEVICETYPE_X8, NULL); +	cfi_send_gen_cmd(0x55, cfi->addr_unlock2,
> chip->start, map, cfi, CFI_DEVICETYPE_X8, NULL); +	cfi_send_gen_cmd(0x90,
> cfi->addr_unlock1, chip->start, map, cfi, CFI_DEVICETYPE_X8, NULL);
> +	cfi_send_gen_cmd(0x00, cfi->addr_unlock1, chip->start, map, cfi,
> CFI_DEVICETYPE_X8, NULL);
>
> Is this always correct?

It should be, it matches the command sequence in the data sheet for the 
AM29DL322D/323D/324D devices. 

>
> +        /* does this chip even have a secsi area? */
> +	if(cfi->mfr!=1)
> +		return -EINVAL;
> +	switch(cfi->id){
> +	case 0x50:
> +	case 0x53:
> +	case 0x55:
> +	case 0x56:
> +	case 0x5C:
> +	case 0x5F:
> +		break;
> +	default:
> +		return -EINVAL;
>
> Er, is this information not available from the CFI info? I really want to
> avoid having stuff like this in the chip drivers.

Unfortunately not. There's no mention of it at all in the AMD primary vendor 
specific extended query table v1.1 which is used on these devices. I don't 
like this method either but in the absence of CFI info I don't have any 
better ideas.

Clive