* RE: cmdline.c file name collision
@ 2002-11-14 22:39 Hicks, Jamey
2002-11-15 9:56 ` Robert Kaiser
0 siblings, 1 reply; 6+ messages in thread
From: Hicks, Jamey @ 2002-11-14 22:39 UTC (permalink / raw)
To: Scott Anderson; +Cc: linux-mtd
I think we should change the filename to avoid the collision in 2.4.x kernels. I do not think we should do surgery on the CVS repository even though that means the file history gets split. I've renamed my copy to cmdlinepart.c in the handhelds.org CVS repository, but I have not done so on the MTD repository. If no one objects, I will add cmdlinepart.c and remove cmdline.c in the infradead cvs.
Jamey
> -----Original Message-----
> From: Scott Anderson [mailto:scott_anderson@mvista.com]
> Sent: Wednesday, November 13, 2002 2:32 PM
> To: Hicks, Jamey
> Cc: linux-mtd@lists.infradead.org
> Subject: Re: cmdline.c file name collision
>
>
> "Hicks, Jamey" wrote:
> > hmm. My first thought was to rename drivers/mtd/cmdline.c to
> > drivers/mtd/mtdcmdline.c or drivers/mtd/cmdlinepart.c.
>
> That sounds reasonable. Does someone that has direct access
> to the CVS
> repository want to move the files around in the repository
> (so we don't
> lose history) or should I just submit a patch that removes
> the file and
> adds the file back with a different name?
>
> > Actually, that was my second thought. My first thought was
> to wonder
> > why CONFIG_MODVERSIONS flattens the kernel source file namespace.
> > I just turned on CONFIG_MODVERSIONS to build an ipaq
> kernel, and I find
> > I also have a name conflict on arch/arm/mach-sa1100/pm.c
> and kernel/pm.c.
>
> I've been told third hand or so that it is a "known
> limitation" in 2.4.
> I just looked in 2.5, and this limitation has been eliminated
> (there is
> a hierarchy of files under include/linux/modules that parallels the
> source hierarchy).
>
> With that new found information, I guess a new question comes up: does
> working around the 2.4 limitation warrant the rename when the
> limitation
> is removed in 2.5?
>
> Scott Anderson
> scott_anderson@mvista.com MontaVista Software Inc.
> (408)328-9214 1237 East Arques Ave.
> http://www.mvista.com Sunnyvale, CA 94085
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cmdline.c file name collision
2002-11-14 22:39 cmdline.c file name collision Hicks, Jamey
@ 2002-11-15 9:56 ` Robert Kaiser
2002-11-15 10:34 ` Frank Neuber
0 siblings, 1 reply; 6+ messages in thread
From: Robert Kaiser @ 2002-11-15 9:56 UTC (permalink / raw)
To: linux-mtd
Am Donnerstag, 14. November 2002 23:39 schrieb Hicks, Jamey:
> I've renamed my copy to
> cmdlinepart.c in the handhelds.org CVS repository, but I have not done so
> on the MTD repository. If no one objects, I will add cmdlinepart.c and
> remove cmdline.c in the infradead cvs.
Why not mtdcmdline.c ? I think it is more important to have the name indicate
the subsystem this file belongs to. The fact that it deals with partitions is
IMHO of minor importance (and might even change in the future).
Rob
----------------------------------------------------------------
Robert Kaiser email: rkaiser@sysgo.de
SYSGO AG
Am Pfaffenstein 14 phone: (49) 6136 9948-762
D-55270 Klein-Winternheim / Germany fax: (49) 6136 9948-10
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cmdline.c file name collision
2002-11-15 9:56 ` Robert Kaiser
@ 2002-11-15 10:34 ` Frank Neuber
0 siblings, 0 replies; 6+ messages in thread
From: Frank Neuber @ 2002-11-15 10:34 UTC (permalink / raw)
To: rkaiser; +Cc: linux-mtd
On Fri, Nov 15, 2002 at 10:56:44AM +0100, Robert Kaiser wrote:
> Am Donnerstag, 14. November 2002 23:39 schrieb Hicks, Jamey:
> > I've renamed my copy to
> > cmdlinepart.c in the handhelds.org CVS repository, but I have not done so
> > on the MTD repository. If no one objects, I will add cmdlinepart.c and
> > remove cmdline.c in the infradead cvs.
>
> Why not mtdcmdline.c ? I think it is more important to have the name indicate
> the subsystem this file belongs to. The fact that it deals with partitions is
> IMHO of minor importance (and might even change in the future).
Yes I agree with you. I use the mtdcmdline.c also to pass the physical map_info.
Frank
--
Dipl.-Ing. Elektrotechnik convergence / HW
Frank Neuber Rosenthalerstr.51 / 10178 Berlin
Email: neuber@convergence.de Phone: +49(0)30-72 62 06 76
WWW: www.convergence.de Fax: +49(0)30-72 62 06 55
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: cmdline.c file name collision
@ 2002-11-13 15:25 Hicks, Jamey
2002-11-13 19:31 ` Scott Anderson
0 siblings, 1 reply; 6+ messages in thread
From: Hicks, Jamey @ 2002-11-13 15:25 UTC (permalink / raw)
To: Scott Anderson, linux-mtd
> -----Original Message-----
> From: Scott Anderson [mailto:scott_anderson@mvista.com]
> Sent: Tuesday, November 12, 2002 12:47 PM
> To: linux-mtd@lists.infradead.org
> Subject: cmdline.c file name collision
>
>
> Hi all,
>
> I recently noticed that when CONFIG_MODVERSIONS is turned on, both
> drivers/mtd/cmdline.c and lib/cmdline.c are trying to store their
> symbol versions in include/linux/modules/cmdline.ver in a 2.4 kernel
> tree. Only one of them "wins" leaving the versioned symbols of the
> other undefined. It seems to me that drivers/mtd/cmdline.c should
> probably be renamed to avoid the conflict. Thoughts?
>
hmm. My first thought was to rename drivers/mtd/cmdline.c to drivers/mtd/mtdcmdline.c or drivers/mtd/cmdlinepart.c.
Actually, that was my second thought. My first thought was to wonder why CONFIG_MODVERSIONS flattens the kernel source file namespace. I just turned on CONFIG_MODVERSIONS to build an ipaq kernel, and I find I also have a name conflict on arch/arm/mach-sa1100/pm.c and kernel/pm.c.
Jamey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cmdline.c file name collision
2002-11-13 15:25 Hicks, Jamey
@ 2002-11-13 19:31 ` Scott Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Scott Anderson @ 2002-11-13 19:31 UTC (permalink / raw)
To: Hicks, Jamey; +Cc: linux-mtd
"Hicks, Jamey" wrote:
> hmm. My first thought was to rename drivers/mtd/cmdline.c to
> drivers/mtd/mtdcmdline.c or drivers/mtd/cmdlinepart.c.
That sounds reasonable. Does someone that has direct access to the CVS
repository want to move the files around in the repository (so we don't
lose history) or should I just submit a patch that removes the file and
adds the file back with a different name?
> Actually, that was my second thought. My first thought was to wonder
> why CONFIG_MODVERSIONS flattens the kernel source file namespace.
> I just turned on CONFIG_MODVERSIONS to build an ipaq kernel, and I find
> I also have a name conflict on arch/arm/mach-sa1100/pm.c and kernel/pm.c.
I've been told third hand or so that it is a "known limitation" in 2.4.
I just looked in 2.5, and this limitation has been eliminated (there is
a hierarchy of files under include/linux/modules that parallels the
source hierarchy).
With that new found information, I guess a new question comes up: does
working around the 2.4 limitation warrant the rename when the limitation
is removed in 2.5?
Scott Anderson
scott_anderson@mvista.com MontaVista Software Inc.
(408)328-9214 1237 East Arques Ave.
http://www.mvista.com Sunnyvale, CA 94085
^ permalink raw reply [flat|nested] 6+ messages in thread
* cmdline.c file name collision
@ 2002-11-12 17:46 Scott Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Scott Anderson @ 2002-11-12 17:46 UTC (permalink / raw)
To: linux-mtd
Hi all,
I recently noticed that when CONFIG_MODVERSIONS is turned on, both
drivers/mtd/cmdline.c and lib/cmdline.c are trying to store their
symbol versions in include/linux/modules/cmdline.ver in a 2.4 kernel
tree. Only one of them "wins" leaving the versioned symbols of the
other undefined. It seems to me that drivers/mtd/cmdline.c should
probably be renamed to avoid the conflict. Thoughts?
Scott Anderson
scott_anderson@mvista.com MontaVista Software Inc.
(408)328-9214 1237 East Arques Ave.
http://www.mvista.com Sunnyvale, CA 94085
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-11-15 10:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-14 22:39 cmdline.c file name collision Hicks, Jamey
2002-11-15 9:56 ` Robert Kaiser
2002-11-15 10:34 ` Frank Neuber
-- strict thread matches above, loose matches on Subject: below --
2002-11-13 15:25 Hicks, Jamey
2002-11-13 19:31 ` Scott Anderson
2002-11-12 17:46 Scott Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox