Compile error in mtdblock-core...

Compile error in mtdblock-core...

[Steven Scholz]

Hi there,

first Happy New Year!

Second:

I just tried to compile the latest linuxppc_2_4_devel patched with the recent
CVS code of MTD using ppc's TQM860L_config.

But I get compiler errors:

ppc_8xx-gcc -D__KERNEL__
-I/opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer
-I/opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/arch/ppc
-fsigned-char -msoft-float -pipe -ffixed-r2 -Wno-uninitialized -mmultiple
-mstring   -nostdinc -I /opt/ELDK/usr/lib/gcc-lib/ppc-linux/2.95.3/include
-DKBUILD_BASENAME=mtdblock_core  -c -o mtdblock-core.o mtdblock-core.c
In file included from
/opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include/linux/blk.h:4,
                 from mtdblock-core.c:18:
/opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include/linux/blkdev.h:147:
parse error before `struct'
make[3]: *** [mtdblock-core.o] Fehler 1

I can't see where this "parse error" is coming from!

Any ideas?

Thanks,

Steven

Re: Compile error in mtdblock-core...

[Thomas Gleixner]

On Monday 06 January 2003 16:19, Steven Scholz wrote:
> -DKBUILD_BASENAME=mtdblock_core  -c -o mtdblock-core.o mtdblock-core.c
> In file included from
> /opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include/linux/blk
>.h:4, from mtdblock-core.c:18:
> /opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include/linux/blk
>dev.h:147: parse error before `struct'
Check in blkdev.h, if the define before the struct contains any control 
characters. Happens sometimes and gcc is not very happy with this. Should not 
be a problem of mtd, because mtd does not modify blkdev.h.
 
-- 
Thomas
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de

Re: Compile error in mtdblock-core...

[Steven Scholz]

Thomas Gleixner wrote:
> 
> On Monday 06 January 2003 16:19, Steven Scholz wrote:
> > -DKBUILD_BASENAME=mtdblock_core  -c -o mtdblock-core.o mtdblock-core.c
> > In file included from
> > /opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include/linux/blk
> >.h:4, from mtdblock-core.c:18:
> > /opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include/linux/blk
> >dev.h:147: parse error before `struct'
> Check in blkdev.h, if the define before the struct contains any control
> characters. Happens sometimes and gcc is not very happy with this. Should not
> be a problem of mtd, because mtd does not modify blkdev.h.

Hmm, I see. But this only happens after I used the patchin script from MTD CSV.
I can't see any control characters in blkdev.h.

Is it working for you? With the latest BitKeeper tree?

Steven

Re: Compile error in mtdblock-core...

[Thomas Gleixner]

On Tuesday 07 January 2003 10:02, Steven Scholz wrote:
> Thomas Gleixner wrote:
> > On Monday 06 January 2003 16:19, Steven Scholz wrote:
> > > -DKBUILD_BASENAME=mtdblock_core  -c -o mtdblock-core.o mtdblock-core.c
> > > In file included from
> > > /opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include/linux
> > >/blk .h:4, from mtdblock-core.c:18:
> > > /opt/BITKEEPER/Exports/linuxppc_2_4_devel-2003-01-06.test/include/linux
> > >/blk dev.h:147: parse error before `struct'
> >
> > Check in blkdev.h, if the define before the struct contains any control
> > characters. Happens sometimes and gcc is not very happy with this. Should
> > not be a problem of mtd, because mtd does not modify blkdev.h.
>
> Hmm, I see. But this only happens after I used the patchin script from MTD
> CSV.
It has nothing to do with patchin. The offending line is 
blkdev.h:147: extern inline int rq_data_dir(struct request *rq)
which is a backport of a 2.5 function

This is also defined in include/linux/mtd/compatmac.h, which is the 
compability header for 2.4/2.5. 

GCC output is not very informative, but with a little intuition and "grep" it 
can be found :)

-- 
Thomas
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de